FSA Refactor WindowsFileDelegate and tests to finish WindowsFileDelegateTest.

This change refactors WindowsFileDelegate, WindowsFileDelegateTest,
and WindowsAclFileAttributeViewsTest to enable testing of rest of
WindowsFileDelegate.  The refactoring does the following:

- Allows for injection of the Windows JNA and WindowsAclFileAttributeViews
  implementations into WindowsFileDelegate.

- Extracts Ace, AceBuilder, AccountSid, Serialized DACL construction,
  temp file management, and TestWindowsAclFileAttributeViews into a base
  class, TestWindowsAclViews, that can be extended by both
  WindowsAclFileAttributeViewsTest and WindowsFileDelegateTest.

This CL is a strict refactoring, and adds no new functionality or tests.

[pjo, 2014-04-17 01:26:17]

Thank you.

https://codereview.appspot.com/88090047/diff/1/test/com/google/enterprise/ada...
File test/com/google/enterprise/adaptor/fs/TestWindowsAclViews.java (right):

https://codereview.appspot.com/88090047/diff/1/test/com/google/enterprise/ada...
test/com/google/enterprise/adaptor/fs/TestWindowsAclViews.java:107: }
are any of the protected methods or members ment to be final?

in particular tempRoot and temp member variables?

[Brett, 2014-04-17 17:15:42]

https://codereview.appspot.com/88090047/diff/1/test/com/google/enterprise/ada...
File test/com/google/enterprise/adaptor/fs/TestWindowsAclViews.java (right):

https://codereview.appspot.com/88090047/diff/1/test/com/google/enterprise/ada...
test/com/google/enterprise/adaptor/fs/TestWindowsAclViews.java:107: }
On 2014/04/17 01:26:17, pjo wrote:
> are any of the protected methods or members ment to be final?
> 
> in particular tempRoot and temp member variables?

They *could* be final, if that is a more appropriate model.

[pjo, 2014-04-17 17:41:45]

Thank you

https://codereview.appspot.com/88090047/diff/1/test/com/google/enterprise/ada...
File test/com/google/enterprise/adaptor/fs/TestWindowsAclViews.java (right):

https://codereview.appspot.com/88090047/diff/1/test/com/google/enterprise/ada...
test/com/google/enterprise/adaptor/fs/TestWindowsAclViews.java:107: }
On 2014/04/17 17:15:42, Brett wrote:
> On 2014/04/17 01:26:17, pjo wrote:
> > are any of the protected methods or members ment to be final?
> > 
> > in particular tempRoot and temp member variables?
> 
> They *could* be final, if that is a more appropriate model.

Why wouldn't they be?
Protected member variables typically scare me.
They're more difficult to follow when having to 
debug or develop additional functionality.
So minimizing their variability is appealing.

What is the aspect of the model that seems useful at this
time?  Can we mark them final now without breaking anything?

Thank you

[Brett, 2014-04-17 18:17:15]

Make protected members and methods of TestWindowsAclViews final.

[Brett, 2014-04-17 18:18:10]

https://codereview.appspot.com/88090047/diff/1/test/com/google/enterprise/ada...
File test/com/google/enterprise/adaptor/fs/TestWindowsAclViews.java (right):

https://codereview.appspot.com/88090047/diff/1/test/com/google/enterprise/ada...
test/com/google/enterprise/adaptor/fs/TestWindowsAclViews.java:107: }
I made them protected simple to make them visible to the subclasses.

All but tempRoot can easily be made final.  getCanonicalFile throws
IOException so initializing a final tempRoot requires some finesse.

[pjo, 2014-04-17 20:15:09]

Thank you.

https://codereview.appspot.com/88090047/diff/20001/test/com/google/enterprise...
File test/com/google/enterprise/adaptor/fs/TestWindowsAclViews.java (right):

https://codereview.appspot.com/88090047/diff/20001/test/com/google/enterprise...
test/com/google/enterprise/adaptor/fs/TestWindowsAclViews.java:53: public final
TemporaryFolder temp = new TemporaryFolder();
public?

https://codereview.appspot.com/88090047/diff/20001/test/com/google/enterprise...
test/com/google/enterprise/adaptor/fs/TestWindowsAclViews.java:63: protected
final Path newTempFile(Path parent, String name) throws IOException {
over80

https://codereview.appspot.com/88090047/diff/20001/test/com/google/enterprise...
test/com/google/enterprise/adaptor/fs/TestWindowsAclViews.java:70: tempRoot =
temp.getRoot().getCanonicalFile().toPath();
Could we make it in ctor? That way we could make it final?

convert exception to runtime one if have to.

[Brett, 2014-04-17 23:54:17]

https://codereview.appspot.com/88090047/diff/20001/test/com/google/enterprise...
File test/com/google/enterprise/adaptor/fs/TestWindowsAclViews.java (right):

https://codereview.appspot.com/88090047/diff/20001/test/com/google/enterprise...
test/com/google/enterprise/adaptor/fs/TestWindowsAclViews.java:53: public final
TemporaryFolder temp = new TemporaryFolder();
On 2014/04/17 20:15:09, pjo wrote:
> public?

@Rule requires it to be public.

https://codereview.appspot.com/88090047/diff/20001/test/com/google/enterprise...
test/com/google/enterprise/adaptor/fs/TestWindowsAclViews.java:63: protected
final Path newTempFile(Path parent, String name) throws IOException {
On 2014/04/17 20:15:09, pjo wrote:
> over80

Done.

https://codereview.appspot.com/88090047/diff/20001/test/com/google/enterprise...
test/com/google/enterprise/adaptor/fs/TestWindowsAclViews.java:70: tempRoot =
temp.getRoot().getCanonicalFile().toPath();
On 2014/04/17 20:15:09, pjo wrote:
> Could we make it in ctor? That way we could make it final?
> 
> convert exception to runtime one if have to.

I tried that, but temp hadn't been set yet.  I'm unsure how
the @Rule works on temp folders.  Can I do something like:

public Foo() {
   @Rule
   temp = new TemporaryFolder();

   try {
     tempRoot = temp.getRoot().getCanonicalFile().toPath();
  } catch (IOException e) {
     throw new IllegalStateExcetion(e);
  }
}

[pjo, 2014-04-18 03:19:17]

Thank you.

https://codereview.appspot.com/88090047/diff/20001/test/com/google/enterprise...
File test/com/google/enterprise/adaptor/fs/TestWindowsAclViews.java (right):

https://codereview.appspot.com/88090047/diff/20001/test/com/google/enterprise...
test/com/google/enterprise/adaptor/fs/TestWindowsAclViews.java:70: tempRoot =
temp.getRoot().getCanonicalFile().toPath();
On 2014/04/17 23:54:18, Brett wrote:
> On 2014/04/17 20:15:09, pjo wrote:
> > Could we make it in ctor? That way we could make it final?
> > 
> > convert exception to runtime one if have to.
> 
> I tried that, but temp hadn't been set yet.  I'm unsure how
> the @Rule works on temp folders.  Can I do something like:
> 
> public Foo() {
>    @Rule
>    temp = new TemporaryFolder();
> 
>    try {
>      tempRoot = temp.getRoot().getCanonicalFile().toPath();
>   } catch (IOException e) {
>      throw new IllegalStateExcetion(e);
>   }
> }


WindowsFileDelegateTest barely needs tempRoot 
and WindowsAclFileAttributeViewsTest doesn't
at all anymore.

Can we either:
# get rid of it and calc every time
# have a protected final method that is called tempRoot()
    that returns it for us (either recalc or from private)

[Brett, 2014-04-18 23:31:49]

Eliminate protected tempRoot field in base class.

[pjo, 2014-04-18 23:33:32]

LGTM.  Thank you

[Brett, 2014-04-18 23:56:43]

Committed 18 April 2014 to File System Adaptor:
To https://code.google.com/p/plexi.fs/
   503f76a..5fffcc9  master -> master