Issue 88081: Add testing support for cvs2svn

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 88081: Add testing support for cvs2svn (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 months, 1 week ago by Collin Winter

Modified:
3 months, 1 week ago

Reviewers:
Jeffrey Yasskin

CC:
unladen-swallow_googlegroups.com

SVN Base:
http://unladen-swallow.googlecode.com/svn/tests/

Visibility:
Public.

Description

This is just the test.py change, not the full checkin of cvs2svn.

Patch Set 1

Total comments: 2

Created: 4 months, 1 week ago

Download raw patch set

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	test.py	View		6 chunks	76 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Jeffrey Yasskin

Otherwise, LGTM http://codereview.appspot.com/88081/diff/1/2 File test.py (right): http://codereview.appspot.com/88081/diff/1/2#newcode159 Line 159: return CheckReturnCode([sys.executable, "-E", "run-tests.py", "-v"]) We ...

4 months, 1 week ago

Collin Winter

http://codereview.appspot.com/88081/diff/1/2 File test.py (right): http://codereview.appspot.com/88081/diff/1/2#newcode159 Line 159: return CheckReturnCode([sys.executable, "-E", "run-tests.py", "-v"]) On 2009/07/03 05:25:35, ...

4 months ago

http://codereview.appspot.com/88081/diff/1/2
File test.py (right):

http://codereview.appspot.com/88081/diff/1/2#newcode159
Line 159: return CheckReturnCode([sys.executable, "-E", "run-tests.py", "-v"])
On 2009/07/03 05:25:35, Jeffrey Yasskin wrote:
> We probably want to print the output on failure.

Yep, CallAndCaptureOutput() already does that.

Expand All Messages | Collapse All Messages