Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4447)

Issue 878042: Added libGLESv2, libEGL, and all samples to GYP. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 7 months ago by Alok Priyadarshi
Modified:
14 years, 7 months ago
Reviewers:
vangelis, kbr1, dgkoch
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Added libGLESv2, libEGL, and all samples to GYP.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+310 lines, -74 lines) Patch
M build/common.gypi View 2 chunks +3 lines, -2 lines 0 comments Download
M samples/build_samples.gyp View 1 chunk +130 lines, -0 lines 0 comments Download
M samples/gles2_book/Common/Win32/esUtil_win32.c View 1 chunk +1 line, -1 line 0 comments Download
M src/build_angle.gyp View 3 chunks +176 lines, -71 lines 0 comments Download

Messages

Total messages: 5
Alok Priyadarshi
14 years, 7 months ago (2010-04-06 17:35:29 UTC) #1
kbr1
LGTM
14 years, 7 months ago (2010-04-06 17:38:58 UTC) #2
dgkoch
Looks good. Daniel
14 years, 7 months ago (2010-04-06 17:44:12 UTC) #3
dgkoch
It would probably be a good idea to add a wiki page an the angleproject ...
14 years, 7 months ago (2010-04-06 17:48:21 UTC) #4
Alok Priyadarshi
14 years, 7 months ago (2010-04-06 17:57:38 UTC) #5
Hi Daniel,
I will add the wiki page. Let me know if you questions in the meantime.

-Alok

On 2010/04/06 17:48:21, dgkoch wrote:
> It would probably be a good idea to add a wiki page an the angleproject about
> how to setup/use GYP as well.
> 
> Thanks,
> Daniel
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b