Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5394)

Issue 8758047: Doc: Remove space before the tie symbol (3133) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by Trevor Daniels
Modified:
11 years ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: Remove space before the tie symbol (3133) This patch changes only the main tie section in the NR. It also tightens the description and corrects a couple of minor errors.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M Documentation/notation/rhythms.itely View 6 chunks +18 lines, -16 lines 0 comments Download

Messages

Total messages: 5
janek
LGTM
11 years ago (2013-04-23 13:26:42 UTC) #1
Graham Percival
I'm not wild about having ties without a space in front of them, but I ...
11 years ago (2013-04-25 15:10:35 UTC) #2
dak
On 2013/04/25 15:10:35, Graham Percival wrote: > I'm not wild about having ties without a ...
11 years ago (2013-04-25 15:20:07 UTC) #3
Jean-Charles
On 2013/04/25 15:20:07, dak wrote: > On 2013/04/25 15:10:35, Graham Percival wrote: > > I'm ...
11 years ago (2013-04-25 16:43:36 UTC) #4
Trevor Daniels
11 years ago (2013-04-25 22:34:06 UTC) #5
On 2013/04/25 16:43:36, Jean-Charles wrote:
> On 2013/04/25 15:20:07, dak wrote:
> > On 2013/04/25 15:10:35, Graham Percival wrote:
> > > I'm not wild about having ties without a space in front of them, but I
can't
> > > think of any rational reason for my reaction, so I guess LGTM.
> > 
> > Oh, there is a perfectly rational reason: ties are placed symmetrically
> between
> > notes, so placing them symmetrically in the source code reflects this
> symmetry.
> > 
> > However, the implementation and the resulting behavior does _not_ have a
> similar
> > symmetry.  Which is not really all that new: we don't have comparable input
> > symmetry with slurs either (though it would be interesting to try).
> 
> Might be because of "one bar per line":
> 
> a4 a a b~
> b4 c c c
> 
> ?
> Otherwise, LGTM
> Jean-Charles

That looks better without a space, certainly,
but the main reason for this change was to try to
avoid leading users into expecting \music ~ f
to work by moving the examples closer to the
implementation - which is that the tie is actually
a starting spanner on the preceding note.

Anyway, pushed to staging as
c78d6ec6a281a0eb6ae042b811bf72ba5b1b618d
Closing ...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b