Issue 8708043: Makes arpeggio horizontal spacing similar to that of accidentals

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8708043: Makes arpeggio horizontal spacing similar to that of accidentals (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by MikeSol

Modified:
11 years ago

Reviewers:
janek

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Makes arpeggio horizontal spacing similar to that of accidentals

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -37 lines)			Patch
M	input/regression/arpeggio-collision.ly	View	3 chunks	+3 lines, -1 line	0 comments	Download
M	lily/arpeggio-engraver.cc	View	4 chunks	+15 lines, -4 lines	0 comments	Download
M	lily/include/note-column.hh	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	lily/note-column.cc	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	lily/paper-column-engraver.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	lily/rhythmic-column-engraver.cc	View	5 chunks	+3 lines, -16 lines	0 comments	Download
M	lily/separation-item.cc	View	2 chunks	+20 lines, -5 lines	0 comments	Download
M	lily/span-arpeggio-engraver.cc	View	6 chunks	+18 lines, -1 line	0 comments	Download
M	scm/define-grob-properties.scm	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

janek

11 years, 1 month ago (2013-04-13 13:50:15 UTC) #1

The code looks reasonable to me; however, it's currently beyond my knowledge to
say whether this is correct approach.

Anyway, the description needs some more background information - why should
arpeggio horizontal spacing be similar to that of accidentals?  A summary of the
discussion that took place in tracker issue would do.

best,
janek

Expand All Messages | Collapse All Messages