Issue 869042: Explain that a template needs arguments to make it into a type

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 869042: Explain that a template needs arguments to make it into a type (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by Jeffrey Yasskin

Modified:
14 years, 9 months ago

Reviewers:
chandlerc

Base URL:
https://llvm.org/svn/llvm-project/cfe/trunk/

Visibility:
Public.

Patch Set 2 : Paint the wording a different color. #

Total comments: 2

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -6 lines)			Patch
M	include/clang/AST/TemplateName.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	include/clang/Basic/DiagnosticSemaKinds.td	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/AST/TemplateName.cpp	View		2 chunks	+14 lines, -0 lines	0 comments	Download
M	lib/Sema/SemaTemplate.cpp	View	1	2 chunks	+16 lines, -1 line	0 comments	Download
M	test/CXX/basic/basic.lookup/basic.lookup.unqual/p7.cpp	View		1 chunk	+2 lines, -2 lines	2 comments	Download
M	test/SemaTemplate/temp_arg_type.cpp	View	1	2 chunks	+13 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

chandlerc

http://codereview.appspot.com/869042/diff/2001/3002 File test/CXX/basic/basic.lookup/basic.lookup.unqual/p7.cpp (right): http://codereview.appspot.com/869042/diff/2001/3002#newcode36 test/CXX/basic/basic.lookup/basic.lookup.unqual/p7.cpp:36: template <class T> struct foo : bar<foo> {}; // ...

14 years, 9 months ago (2010-04-04 09:26:21 UTC) #1

Jeffrey Yasskin

14 years, 9 months ago (2010-04-04 19:00:57 UTC) #2

http://codereview.appspot.com/869042/diff/2001/3002
File test/CXX/basic/basic.lookup/basic.lookup.unqual/p7.cpp (right):

http://codereview.appspot.com/869042/diff/2001/3002#newcode36
test/CXX/basic/basic.lookup/basic.lookup.unqual/p7.cpp:36: template <class T>
struct foo : bar<foo> {}; // expected-error {{class template-name foo requires
template arguments to produce a type}} expected-note {{template is declared
here}}
On 2010/04/04 09:26:21, chandlerc wrote:
> It would be nice to special case this to a single precise message and provide
a
> fixit suggesting <T> as the argument. That said, I don't know how much code
that
> would be to implement, so it might not be worth while.

It would definitely be nice. Not in this patch though.

Expand All Messages | Collapse All Messages