Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1701)

Issue 8686: * use correct left to right ordering in keySignature list (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 4 months ago by Reinhold
Modified:
14 years, 8 months ago
Reviewers:
hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

* use correct left to right ordering in keySignature list The keySignature property list of the KeySignature so far was using reversed order (e.g. the rightmost accidental came first). This was quite confusing when manually setting non-standard key signatures like \set Staff.keySignature = #`(((0 . 3) . ,SHARP) ((0 . 5) . ,FLAT) ((0 . 6) . ,FLAT)) In this example, you'll get bes, as, fis in that reversed order rather than in the order in which you list the alterations.

Patch Set 1 #

Patch Set 2 : Also fix snippets and musicxml2ly; add conversion rule to warn users of the keySignature property #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -19 lines) Patch
M input/lsr/makam-example.ly View 1 chunk +1 line, -1 line 0 comments Download
M input/lsr/non-traditional-key-signatures.ly View 2 chunks +3 lines, -4 lines 0 comments Download
M input/new/revised/non-traditional-key-signatures.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/key-signature-padding.ly View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/key-signature-scordatura.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/keys.ly View 1 chunk +1 line, -1 line 0 comments Download
M lily/key-engraver.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M python/convertrules.py View 1 chunk +8 lines, -0 lines 0 comments Download
M python/musicexp.py View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2
hanwenn
Shouldn't there be changes in other files to correspond? (do we have a regtest?)
15 years, 4 months ago (2008-12-23 13:46:14 UTC) #1
hanwenn
15 years, 2 months ago (2009-02-20 14:46:24 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b