Issue 8668044: skyline.cc: No zero-width empty buildings between buildings; issue 3311

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8668044: skyline.cc: No zero-width empty buildings between buildings; issue 3311 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by Keith

Modified:
10 years, 11 months ago

Reviewers:
janek

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

skyline.cc: No zero-width empty buildings between buildings; issue 3311

Patch Set 1 #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	lily/skyline.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

janek

11 years ago (2013-04-13 11:27:29 UTC) #1

LGTM
this is much clearer (and i think also better) than Mike's patch.

https://codereview.appspot.com/8668044/diff/1/lily/skyline.cc
File lily/skyline.cc (right):

https://codereview.appspot.com/8668044/diff/1/lily/skyline.cc#newcode389
lily/skyline.cc:389: if (x1 > last_end)
I suggest to add a comment: "Avoid creating zero-width empty buildings"

Expand All Messages | Collapse All Messages