Issue 8632044: Gives MetronomeMark default skyline-horizontal-padding of 0.2

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8632044: Gives MetronomeMark default skyline-horizontal-padding of 0.2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by MikeSol

Modified:
11 years ago

Reviewers:
Keith, janek, lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Gives MetronomeMark default skyline-horizontal-padding of 0.2

Patch Set 1 #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	scm/define-grobs.scm	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Keith

11 years ago (2013-04-19 06:55:10 UTC) #3

Looks fine, but I thought you wanted to use only one of
  outside-staff-horizontal-padding 
or 
  skyline-horizontal-padding

I need to be clear on this because I'm implementing \markLengthOn and the
analogous \textLengthOn needed to remove these paddings.

https://codereview.appspot.com/8632044/diff/1/scm/define-grobs.scm
File scm/define-grobs.scm (right):

https://codereview.appspot.com/8632044/diff/1/scm/define-grobs.scm#newcode1419
scm/define-grobs.scm:1419: (outside-staff-horizontal-padding . 0.12)
So, padding is 0.32 if the mark is outside the staff ?

Expand All Messages | Collapse All Messages