Issue 8624045: Enhance the LIPO support in AutoFDO

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8624045: Enhance the LIPO support in AutoFDO

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by dehao

Modified:
10 years, 12 months ago

Reviewers:
davidxl

Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/gcc-4_7/

Visibility:
Public.

More Reviews

Patch Set 2 : 1 #

Created: 10 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -15 lines)			Patch
M	gcc/auto-profile.c	View	1	8 chunks	+58 lines, -7 lines	0 comments	Download
M	gcc/c-family/c-opts.c	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	gcc/common.opt	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	gcc/coverage.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	gcc/coverage.c	View	1	3 chunks	+19 lines, -3 lines	0 comments	Download
M	gcc/opts.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	gcc/toplev.c	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

davidxl

https://codereview.appspot.com/8624045/diff/1/gcc/auto-profile.c File gcc/auto-profile.c (right): https://codereview.appspot.com/8624045/diff/1/gcc/auto-profile.c#newcode336 gcc/auto-profile.c:336: || (func1 != NULL && func2 != NULL && ...

10 years, 12 months ago (2013-04-29 18:08:52 UTC) #1

dehao

10 years, 12 months ago (2013-04-30 22:34:17 UTC) #2

LGTM.

Expand All Messages | Collapse All Messages