Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13239)

Issue 8614045: change OctavateEight to ClefModifier

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by janek
Modified:
11 years ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

change OctavateEight to ClefModifier Name "OctavateEight" didn't make any sense. The grob doesn't have to be an eight, and it doesn't describe octavation, but arbitrary transposition (not only whole octaves). Also, the name should reflect its affiliation with Clef grob. Also change related context properties.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -253 lines) Patch
M Documentation/changes.tely View 2 chunks +6 lines, -1 line 0 comments Download
M Documentation/cs/learning/fundamental.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/de/learning/fundamental.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/de/notation/changing-defaults.itely View 3 chunks +4 lines, -4 lines 0 comments Download
M Documentation/de/notation/pitches.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/de/notation/vocal.itely View 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/de/texidocs/tweaking-clef-properties.texidoc View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/es/learning/fundamental.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/es/notation/changing-defaults.itely View 4 chunks +5 lines, -5 lines 0 comments Download
M Documentation/es/notation/pitches.itely View 2 chunks +4 lines, -4 lines 0 comments Download
M Documentation/es/notation/vocal.itely View 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/es/texidocs/tweaking-clef-properties.texidoc View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/fr/learning/fundamental.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/fr/notation/changing-defaults.itely View 3 chunks +4 lines, -4 lines 0 comments Download
M Documentation/fr/notation/pitches.itely View 2 chunks +4 lines, -4 lines 0 comments Download
M Documentation/fr/notation/vocal.itely View 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/fr/texidocs/tweaking-clef-properties.texidoc View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/hu/learning/fundamental.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/it/learning/fundamental.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/it/notation/pitches.itely View 2 chunks +4 lines, -4 lines 0 comments Download
M Documentation/it/texidocs/tweaking-clef-properties.texidoc View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/ja/learning/fundamental.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/ja/notation/changing-defaults.itely View 4 chunks +8 lines, -8 lines 0 comments Download
M Documentation/ja/notation/pitches.itely View 2 chunks +4 lines, -4 lines 0 comments Download
M Documentation/ja/notation/vocal.itely View 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/learning/fundamental.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/nl/learning/fundamental.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/notation/changing-defaults.itely View 4 chunks +12 lines, -12 lines 0 comments Download
M Documentation/notation/pitches.itely View 2 chunks +4 lines, -4 lines 0 comments Download
M Documentation/notation/vocal.itely View 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/snippets/tweaking-clef-properties.ly View 5 chunks +7 lines, -7 lines 0 comments Download
M input/regression/clef-oct-visibility.ly View 2 chunks +3 lines, -3 lines 0 comments Download
D input/regression/clef-octavation.ly View 1 chunk +0 lines, -18 lines 0 comments Download
D input/regression/clef-optional-octavation.ly View 1 chunk +0 lines, -15 lines 0 comments Download
A + input/regression/clef-optional-transposition.ly View 1 chunk +2 lines, -2 lines 0 comments Download
A + input/regression/clef-transposition.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/beam-collision-engraver.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M lily/clef-engraver.cc View 10 chunks +17 lines, -17 lines 0 comments Download
M lily/cue-clef-engraver.cc View 11 chunks +21 lines, -21 lines 0 comments Download
M ly/engraver-init.ly View 5 chunks +6 lines, -6 lines 0 comments Download
M python/convertrules.py View 1 chunk +13 lines, -0 lines 0 comments Download
M scm/define-context-properties.scm View 2 chunks +10 lines, -8 lines 0 comments Download
M scm/define-grob-interfaces.scm View 2 chunks +7 lines, -8 lines 0 comments Download
M scm/define-grobs.scm View 3 chunks +25 lines, -26 lines 0 comments Download
M scm/define-music-display-methods.scm View 2 chunks +6 lines, -6 lines 0 comments Download
M scm/parser-clef.scm View 4 chunks +10 lines, -10 lines 0 comments Download
M scm/translation-functions.scm View 1 chunk +4 lines, -4 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b