Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1020)

Issue 8613043: Add changes entry for Mike's work on skylines.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by janek
Modified:
11 years ago
Reviewers:
Keith, dak, mike7, MikeSol, Trevor Daniels, wl
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add changes entry for Mike's work on skylines.

Patch Set 1 #

Patch Set 2 : list affected grobs" #

Patch Set 3 : typo and clef omission #

Total comments: 6

Patch Set 4 : fixes from keith #

Patch Set 5 : include too snug articulations #

Patch Set 6 : fix silly typo #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M Documentation/changes.tely View 1 2 3 4 5 1 chunk +35 lines, -0 lines 2 comments Download

Messages

Total messages: 25
janek
list affected grobs"
11 years ago (2013-04-10 08:41:33 UTC) #1
janek
typo and clef omission
11 years ago (2013-04-10 17:14:22 UTC) #2
Keith
lgtm https://codereview.appspot.com/8613043/diff/5001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/8613043/diff/5001/Documentation/changes.tely#newcode156 Documentation/changes.tely:156: using an integral-like approach. This generally results in ...
11 years ago (2013-04-12 06:53:34 UTC) #3
janek
fixes from keith
11 years ago (2013-04-12 10:23:56 UTC) #4
janek
https://codereview.appspot.com/8613043/diff/5001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/8613043/diff/5001/Documentation/changes.tely#newcode156 Documentation/changes.tely:156: using an integral-like approach. This generally results in more ...
11 years ago (2013-04-12 10:24:46 UTC) #5
Keith
On Fri, 12 Apr 2013 03:24:46 -0700, <janek.lilypond@gmail.com> wrote: > https://codereview.appspot.com/8613043/diff/5001/Documentation/changes.tely#newcode162 > Documentation/changes.tely:162: c'4\f a4\f ...
11 years ago (2013-04-13 03:21:23 UTC) #6
janek
include too snug articulations
11 years ago (2013-04-13 13:03:36 UTC) #7
janek
2013/4/13 Keith OHara <k-ohara5a5a@oco.net>: > On Fri, 12 Apr 2013 03:24:46 -0700, <janek.lilypond@gmail.com> wrote: >> ...
11 years ago (2013-04-13 13:12:48 UTC) #8
janek
fix silly typo
11 years ago (2013-04-13 21:15:36 UTC) #9
MikeSol
https://codereview.appspot.com/8613043/diff/19001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/8613043/diff/19001/Documentation/changes.tely#newcode153 Documentation/changes.tely:153: @item I would add a note that, if there ...
11 years ago (2013-04-16 06:05:42 UTC) #10
dak
On 2013/04/16 06:05:42, MikeSol wrote: > https://codereview.appspot.com/8613043/diff/19001/Documentation/changes.tely > File Documentation/changes.tely (right): > > https://codereview.appspot.com/8613043/diff/19001/Documentation/changes.tely#newcode153 > ...
11 years ago (2013-04-16 07:20:59 UTC) #11
Trevor Daniels
On 2013/04/16 07:20:59, dak wrote: > On 2013/04/16 06:05:42, MikeSol wrote: >> I would add ...
11 years ago (2013-04-16 07:40:19 UTC) #12
dak
On 2013/04/16 07:40:19, Trevor Daniels wrote: > On 2013/04/16 07:20:59, dak wrote: > > On ...
11 years ago (2013-04-16 07:51:46 UTC) #13
Trevor Daniels
On 2013/04/16 07:51:46, dak wrote: > So for a stable release, we need conservative > ...
11 years ago (2013-04-16 08:28:40 UTC) #14
MikeSol
On 2013/04/16 07:51:46, dak wrote: > On 2013/04/16 07:40:19, Trevor Daniels wrote: > > On ...
11 years ago (2013-04-16 08:34:43 UTC) #15
dak
On 2013/04/16 08:34:43, MikeSol wrote: > On 2013/04/16 07:51:46, dak wrote: > > > > ...
11 years ago (2013-04-16 09:59:03 UTC) #16
mike7
On 16 avr. 2013, at 12:59, dak@gnu.org wrote: > On 2013/04/16 08:34:43, MikeSol wrote: >> ...
11 years ago (2013-04-16 10:24:28 UTC) #17
wl_gnu.org
> So we need feedback from the heavy hitters, and we have annoyingly > few ...
11 years ago (2013-04-16 10:45:52 UTC) #18
janek
2013/4/16 <dak@gnu.org>: > I hate it when I get last-minute realizations. Here is another thing ...
11 years ago (2013-04-16 11:11:03 UTC) #19
Keith
https://codereview.appspot.com/8613043/diff/19001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/8613043/diff/19001/Documentation/changes.tely#newcode160 Documentation/changes.tely:160: #(ly:set-option 'debug-skylines #t) \override Score.MetronomeMark #'skyline-horizontal-padding = #0.2 \override ...
11 years ago (2013-04-16 17:02:04 UTC) #20
dak
On 2013/04/16 11:11:03, janek wrote: > 2013/4/16 <dak@gnu.org>: > > I hate it when I ...
11 years ago (2013-04-16 19:12:12 UTC) #21
mike7
On 16 avr. 2013, at 22:12, dak@gnu.org wrote: > On 2013/04/16 11:11:03, janek wrote: >> ...
11 years ago (2013-04-16 19:20:13 UTC) #22
Keith
On Tue, 16 Apr 2013 12:15:23 -0700, mike@mikesolomon.org <mike@mikesolomon.org> wrote: > > On 16 avr. ...
11 years ago (2013-04-17 01:03:05 UTC) #23
Keith
On Tue, 16 Apr 2013 04:10:32 -0700, Janek Warchoł <janek.lilypond@gmail.com> wrote: > 2013/4/16 <dak@gnu.org>: >> ...
11 years ago (2013-04-17 01:03:05 UTC) #24
janek
11 years ago (2013-04-17 20:40:24 UTC) #25
2013/4/17 Keith OHara <k-ohara5a5a@oco.net>:
> On Tue, 16 Apr 2013 04:10:32 -0700, Janek Warchoł <janek.lilypond@gmail.com>
> wrote:
>
>> 2013/4/16  <dak@gnu.org>:
>>> So what we need is not a vote.  What we need is as much feedback as we
>>> can get about cases considered problematic, and we need to see whether
>>> we can change defaults in a way where they cease being a problem, at
>>> least to the degree where people will not bother fiddling with
>>> overrides in order to get rid of them.
>>
>> I agree except for the fact that i already think its impossible to
>> tweak defaults to achieve this.
>
>
> Then let's un-tweak the defaults for Lyrics.  Sure, some padding helped in
> your "Tota pulchra" but it might result in wrong placement in other cases,
> so we should remove it:
>
> \new ChoirStaff <<
>   \new Lyrics = "s"
>   \new Staff = "staff" <<
>     \new Voice = "s"  \transpose c c'' { \voiceOne d4 d }
>     \new Voice = "a"  \transpose c c' { \voiceTwo d4 d } >>
>   \new Lyrics = "s" \with { alignAboveContext = "staff" }
>   \context Lyrics = "s" \lyricsto "s" { Ni }
>   \context Lyrics = "a" \lyricsto "a" { j  lli } >>
> \layout { \context {\Lyrics
>     \override VerticalAxisGroup #'nonstaff-relatedstaff-spacing = #'()
>     \override LyricText #'skyline-horizontal-padding = #0 }}

Well, that's indeed amazingly ugly example.
I apologize if my email sounded unfriedndly and/or disparaging.  I
agree that we need sane defaults for skylines, and i admit that
there's room for improvement from the current state.  I'll report any
problematic skyline case if i encounter one.

all the best,
Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b