Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(26)

Issue 861041: ns-3: Use consistent standards/rates for examples and tests that use Wi-Fi (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 8 months ago by Dean
Modified:
14 years, 5 months ago
Reviewers:
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

The change to consider mandatory rates for control responses if a suitable basic rate could not be found (available here for review as Issue 855042) broke the tests involving the wireless/wifi-simple-adhoc-grid example, and the routing-olsr-regression testsuite. In these cases it is actually the tests that are at fault - in the wifi-simple-adhoc-grid test and the bug780-test part of the routing-olsr-regression testsuite, 802.11b rates were being used with the Wi-Fi PHY standard left at the default of 802.11a. The fix here is to set the standard to 802.11b in the test. In the tx-regression-test part of routing-olsr-regression, the problem was that the reference traces needed to be updated given the control response rate fix. In this case I have also modified the test to set the standard to 802.11a for clarity.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M examples/wireless/wifi-simple-adhoc-grid.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/routing/olsr/test/bug780-0-0.pcap View Binary file 0 comments Download
M src/routing/olsr/test/bug780-1-0.pcap View Binary file 0 comments Download
M src/routing/olsr/test/bug780-2-0.pcap View Binary file 0 comments Download
M src/routing/olsr/test/bug780-test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/routing/olsr/test/tc-regression-test.cc View 1 chunk +1 line, -0 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b