FSA Fix b/1753517: Hidden Folders should not be crawled.

FSA Fix b/1753517: Hidden Folders should not be crawled.

This fixes a bug in NioFileDelegate.isHidden().
It seems that NIO Files.isHidden(Path) does not consider hidden
folders to be hidden.  From the NIO Files javadoc:
"On Windows a file is considered hidden if it isn't a directory
 and the DOS hidden attribute is set."

I don't know why Sun/Oracle decided to exclude hidden directories.
Consequently, I changed the implementation to use File.isHidden(),
which does pay attention to the hidden attribute on directories.

[pjo, 2014-04-09 22:42:00]

LGTM.  Thank you.


- technology's compounding interest
-


On Wed, Apr 9, 2014 at 3:17 PM, <Brett.Michael.Johnson@gmail.com> wrote:

> Reviewers: pjo, mifern,
>
> Description:
> FSA Fix b/1753517: Hidden Folders should not be crawled.
>
> This fixes a bug in NioFileDelegate.isHidden().
> It seems that NIO Files.isHidden(Path) does not consider hidden
> folders to be hidden.  From the NIO Files javadoc:
> "On Windows a file is considered hidden if it isn't a directory
>  and the DOS hidden attribute is set."
>
> I don't know why Sun/Oracle decided to exclude hidden directories.
> Consequently, I changed the implementation to use File.isHidden(),
> which does pay attention to the hidden attribute on directories.
>
>
>
> Please review this at http://codereview.appspot.com/85580045/
>
> Affected files (+3, -1 lines):
>   M src/com/google/enterprise/adaptor/fs/NioFileDelegate.java
>
>
> Index: src/com/google/enterprise/adaptor/fs/NioFileDelegate.java
> diff --git a/src/com/google/enterprise/adaptor/fs/NioFileDelegate.java
> b/src/com/google/enterprise/adaptor/fs/NioFileDelegate.java
> index 80bdbe814a7711e22753f3a27fc411083fc24c57..
> 84ab250e76ebd2b908b6c2ff5d7ed13329a432eb 100644
> --- a/src/com/google/enterprise/adaptor/fs/NioFileDelegate.java
> +++ b/src/com/google/enterprise/adaptor/fs/NioFileDelegate.java
> @@ -53,7 +53,9 @@ abstract class NioFileDelegate implements FileDelegate {
>
>    @Override
>    public boolean isHidden(Path doc) throws IOException {
> -    return Files.isHidden(doc);
> +    // Using File.isHidden() because NIO Files.isHidden(Path) does not
> +    // consider hidden directories to be hidden.
> +    return doc.toFile().isHidden();
>    }
>
>    @Override
>
>
>

[Brett, 2014-04-09 23:33:33]

Committed 09 April 2014 to File System Adaptor:

To https://code.google.com/p/plexi.fs/
   22b6a21..0b9554d  master -> master