Issue 8514043: Removes arpeggios from note columns' element list.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8514043: Removes arpeggios from note columns' element list. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by MikeSol

Modified:
11 years ago

Reviewers:
Keith

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Removes arpeggios from note columns' element list. Arpeggios are still used in horizontal spacing of note columns in separation-item.cc

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -3 lines)			Patch
M	input/regression/arpeggio-collision.ly	View	1	3 chunks	+3 lines, -1 line	0 comments	Download
M	lily/rhythmic-column-engraver.cc	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	lily/separation-item.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 2

Keith

lgtm. You should add a test that would reveal if the problem in issue 3289 ...

11 years ago (2013-04-08 17:17:32 UTC) #1

Modifies regtest