On 2013/04/08 06:35:48, lemzwerg wrote: > LGTM. Do we have a regtest for this? Yes, ...
11 years, 1 month ago
(2013-04-08 17:13:57 UTC)
#2
On 2013/04/08 06:35:48, lemzwerg wrote:
> LGTM. Do we have a regtest for this?
Yes, because several tests already have repeat bars at the start of lines. They
look noticeably odd before this patch, so I think they can serve to alert us if
this patch ever fails in the future.
What if a non-repeat barline is placed after a break? Do i understand correctly
that this patch will also place it after time sig, and is this what we want?
Janek
On Sat, 13 Apr 2013 07:21:17 -0700, <janek.lilypond@gmail.com> wrote:
> What if a non-repeat barline is placed after a break? Do i understand
> correctly that this patch will also place it after time sig, and is this
> what we want?
>
Yes it would place the bar-line after the time signature. The only bar-lines at
the beginning of a line are repeats, and the similar segno:
{ b4 b b b \break \time 2/2 \key d\major
\bar "S" b b b b }
We want the double bar before the key-change and time-signature at the end of
the line, and the ยง after the prefatory matter on the next line (and get this
after the patch).
On 2013/04/14 17:08:58, janek wrote:
> LGTM then.
> thanks,
> Janek
PS it may be worth changing commit message so that it's obvious that not only
repeat bars behaviour should change.
Issue 8508043: Time signature before repeat bars at beginning of line; issue 828
(Closed)
Created 11 years, 1 month ago by Keith
Modified 10 years, 12 months ago
Reviewers: lemzwerg, janek
Base URL:
Comments: 0