Issue 84960045: Issue 3894: accidental rule 'teaching' broke

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 84960045: Issue 3894: accidental rule 'teaching' broke (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by dak

Modified:
9 years, 6 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Issue 3894: accidental rule 'teaching' broke Revert part of "Issue 2745: more fun with accidental rules." This reverts the part of commit bbca17061fbc7a25ca4050e6d031b3e9562b658e that deals with the teaching accidental rule. Frankly: I don't understand how the change was supposed to work at all. Nor do I understand why undoing it flags actual accidentals in the key signature while not showing naturals.

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -6 lines)			Patch
	M	scm/music-functions.scm	View		2 chunks	+10 lines, -6 lines	0 comments	Download