Issue 849043: Removed tabs. Fixed formatting. Only white-space changes.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 849043: Removed tabs. Fixed formatting. Only white-space changes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 1 month ago by Alok Priyadarshi

Modified:
16 years, 1 month ago

Reviewers:
kbr1, dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Removed tabs. Fixed formatting. Only white-space changes.

Patch Set 2 : '' #

Created: 16 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1302 lines, -1304 lines)			Patch
	M	src/compiler/Intermediate.cpp	View		21 chunks	+1005 lines, -1005 lines	0 comments	Download
	M	src/compiler/intermediate.h	View	1	12 chunks	+297 lines, -299 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Alok Priyadarshi

http://codereview.appspot.com/849043/diff/1/3 File src/compiler/intermediate.h (right): http://codereview.appspot.com/849043/diff/1/3#newcode456 src/compiler/intermediate.h:456: depth(0) {} only white-space changes except this one. moved ...

16 years, 1 month ago (2010-03-30 19:11:21 UTC) #1

kbr1

LGTM http://codereview.appspot.com/849043/diff/1/3 File src/compiler/intermediate.h (right): http://codereview.appspot.com/849043/diff/1/3#newcode132 src/compiler/intermediate.h:132: // EOpFwidth, // Fragment only, OES_standard_derivatives extension Still ...

16 years, 1 month ago (2010-03-30 19:15:38 UTC) #2

Alok Priyadarshi

16 years, 1 month ago (2010-03-30 19:36:00 UTC) #3

http://codereview.appspot.com/849043/diff/1/3
File src/compiler/intermediate.h (right):

http://codereview.appspot.com/849043/diff/1/3#newcode132
src/compiler/intermediate.h:132: //	EOpFwidth,          // Fragment only,
OES_standard_derivatives extension
On 2010/03/30 19:15:39, kbr1 wrote:
> Still have some tabs here.
> 

Done.

Expand All Messages | Collapse All Messages