Issue 849042: Added support for user-defined structs. And fixed a bug in function return ty...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 849042: Added support for user-defined structs. And fixed a bug in function return ty... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by Alok Priyadarshi

Modified:
15 years, 4 months ago

Reviewers:
vangelis, kbr1, dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Added support for user-defined structs. And fixed a bug in function return type.

Patch Set 3 : '' #

Total comments: 4

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -11 lines)			Patch
M	src/compiler/Intermediate.cpp	View	1 2	1 chunk	+3 lines, -3 lines	3 comments	Download
M	src/compiler/OutputGLSL.cpp	View	1	4 chunks	+20 lines, -5 lines	0 comments	Download
M	src/compiler/OutputHLSL.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/intermediate.h	View	1	1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

kbr1

LGTM http://codereview.appspot.com/849042/diff/6001/7001 File src/compiler/Intermediate.cpp (right): http://codereview.appspot.com/849042/diff/6001/7001#newcode800 src/compiler/Intermediate.cpp:800: getTypePointer()->setArrayInformationType(left->getType().getArrayInformationType()); tabs http://codereview.appspot.com/849042/diff/6001/7002 File src/compiler/intermediate.h (right): http://codereview.appspot.com/849042/diff/6001/7002#newcode235 src/compiler/intermediate.h:235: ...

15 years, 4 months ago (2010-03-30 17:31:02 UTC) #2

Alok Priyadarshi

Regarding tabs: The two old files are full of tabs. I will remove them in ...

15 years, 4 months ago (2010-03-30 17:52:45 UTC) #3

dgkoch

approved. http://codereview.appspot.com/849042/diff/6001/7001 File src/compiler/Intermediate.cpp (right): http://codereview.appspot.com/849042/diff/6001/7001#newcode800 src/compiler/Intermediate.cpp:800: getTypePointer()->setArrayInformationType(left->getType().getArrayInformationType()); Or perhaps more accurately, line 799 *doesn't* ...

15 years, 4 months ago (2010-03-30 18:25:56 UTC) #4

Alok Priyadarshi

15 years, 4 months ago (2010-03-30 18:46:50 UTC) #5

http://codereview.appspot.com/849042/diff/6001/7001
File src/compiler/Intermediate.cpp (right):

http://codereview.appspot.com/849042/diff/6001/7001#newcode800
src/compiler/Intermediate.cpp:800:
getTypePointer()->setArrayInformationType(left->getType().getArrayInformationType());
My visual studio preferences replace tabs with spaces, so it is difficult to add
tabs on new lines. I will remove the tabs in a different CL.

Expand All Messages | Collapse All Messages