Issue 84860044: Fix namespace issue with clang.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 84860044: Fix namespace issue with clang. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by pkx166h

Modified:
10 years ago

Reviewers:
Devon Schudy

CC:
lilypond-devel_gnu.org, wiz_netbsd.org

Visibility:
Public.

More Reviews

Description

Fix namespace issue with clang. Signed-off-by: Thomas Klausner <wiz@NetBSD.org>

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	lily/misc.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Devon Schudy

LGTM. This works in clang 3.2, so it took me a while to figure out ...

10 years ago (2014-04-11 06:48:40 UTC) #1

pkx166h

10 years ago (2014-04-12 06:55:04 UTC) #2

author	Thomas Klausner <wiz@NetBSD.org>	
	Sun, 6 Apr 2014 17:17:30 +0000 (19:17 +0200)
committer	James Lowe <pkx166h@gmail.com>	
	Sat, 12 Apr 2014 06:51:43 +0000 (07:51 +0100)
commit	3d456562eb14c3dc8515038a25a2dde24b2486b8

Expand All Messages | Collapse All Messages