Adding check on Replicated classes

I have added code to check to make sure that there are no cascades from non-replicated entities to replicated entities.

[danny.antonetti, 2008-11-10 16:07:07]

Here are my changes to enable detection of bad cascades.
Most of the change is for the test cases.

[Max Ross, 2008-11-16 21:58:47]

Great start Danny!  Mostly style nits, but one big question:
Is this CL supposed to contain the logic that restricts the persistence of
replicated entities to a single shard, or are you saving that for a separate CL?
 I'm ok with a separate CL, I just want to make sure I understand where this is
going.

Thanks,
Max

http://codereview.appspot.com/8456/diff/1/22
File java/org/hibernate/shards/ShardedConfiguration.java (right):

http://codereview.appspot.com/8456/diff/1/22#newcode201
Line 201: * Specifically there should be no cascades from classes that are not
replicated, and classes that are replicated.
Please explain why such cascades are problematic.

http://codereview.appspot.com/8456/diff/1/22#newcode207
Line 207: Iterator<PersistentClass> persistentClasses =
(Iterator<PersistentClass>) this.prototypeConfiguration.getClassMappings();
nit: no need for 'this' prefix.  We just do this in constructors and setters
when there are params with the same names as the member.

http://codereview.appspot.com/8456/diff/1/22#newcode211
Line 211: if (psClass.isAnnotationPresent(Replicated.class)) continue;
Please use curly braces even for one line conditionals, and put the 'continue'
on its own line.

http://codereview.appspot.com/8456/diff/1/22#newcode218
Line 218: if (cascade==null || cascade.equalsIgnoreCase("NONE")) continue;
see above style comment

http://codereview.appspot.com/8456/diff/1/22#newcode218
Line 218: if (cascade==null || cascade.equalsIgnoreCase("NONE")) continue;
Is there really no constant in Hibernate core that we can refer to instead of
the hard-coded 'NONE' string?

http://codereview.appspot.com/8456/diff/1/22#newcode221
Line 221: throw new InvalidMappingException("Illegal cascade from non-replicated
class(property="+ps.getClassName()+") to replilcated
class("+property.getName()+")",psClass.toString(), (String)null);
replilcated -> replicated

http://codereview.appspot.com/8456/diff/1/22#newcode221
Line 221: throw new InvalidMappingException("Illegal cascade from non-replicated
class(property="+ps.getClassName()+") to replilcated
class("+property.getName()+")",psClass.toString(), (String)null);
If you just throw MappingException you can skip the unused param at the end. 
Also, I don't think property.getName() returns a class.  Ideally this message
would include the name of the non-replicated class, the name of the replicated
class, and the name of the property on the replicated class that is of the type
of the replicated class.

http://codereview.appspot.com/8456/diff/1/24
File java/org/hibernate/shards/strategy/selection/Replicated.java (right):

http://codereview.appspot.com/8456/diff/1/24#newcode1
Line 1: package org.hibernate.shards.strategy.selection;
Please add the apache license to the top.  Just look at the other files (you can
omit Copyright Google).

http://codereview.appspot.com/8456/diff/1/24#newcode12
Line 12: * User: dantonetti
Please add an author tag like the other files have.  Your choice whether to put
your email address or not.

http://codereview.appspot.com/8456/diff/1/25
File java/org/hibernate/shards/util/Lists.java (right):

http://codereview.appspot.com/8456/diff/1/25#newcode31
Line 31: public class  Lists {
extra space

http://codereview.appspot.com/8456/diff/1/25#newcode55
Line 55: * @return
Please provide a value for @return.

http://codereview.appspot.com/8456/diff/1/3
File
test/org/hibernate/shards/integration/model/ModelCriteriaPermutedIntegrationTest.java
(right):

http://codereview.appspot.com/8456/diff/1/3#newcode61
Line 61: s = ModelDataFactory.state("s1");
indentation.  we use 2 spaces, no tabs

http://codereview.appspot.com/8456/diff/1/2
File test/org/hibernate/shards/integration/model/ModelDataFactory.java (right):

http://codereview.appspot.com/8456/diff/1/2#newcode129
Line 129: public static City city(String name, State s) {
spacing

http://codereview.appspot.com/8456/diff/1/11
File test/org/hibernate/shards/model/City.java (right):

http://codereview.appspot.com/8456/diff/1/11#newcode1
Line 1: package org.hibernate.shards.model;
apache license

http://codereview.appspot.com/8456/diff/1/11#newcode9
Line 9: * Created by IntelliJ IDEA.
Please change to match other shards source files

http://codereview.appspot.com/8456/diff/1/11#newcode16
Line 16: public class City {
indentation

http://codereview.appspot.com/8456/diff/1/10
File test/org/hibernate/shards/model/State.java (right):

http://codereview.appspot.com/8456/diff/1/10#newcode1
Line 1: package org.hibernate.shards.model;
apache license

http://codereview.appspot.com/8456/diff/1/10#newcode10
Line 10: * User: dantonetti
please change to match other shards source files

http://codereview.appspot.com/8456/diff/1/10#newcode17
Line 17: private String name;
indentation

http://codereview.appspot.com/8456/diff/1/18
File test/org/hibernate/shards/testmodel/replicationtest/NotReplicated.java
(right):

http://codereview.appspot.com/8456/diff/1/18#newcode1
Line 1: package org.hibernate.shards.testmodel.replicationtest;
apache license

http://codereview.appspot.com/8456/diff/1/18#newcode11
Line 11: * User: dantonetti
please change to match other shards source files

http://codereview.appspot.com/8456/diff/1/18#newcode19
Line 19: @Id
indentation

http://codereview.appspot.com/8456/diff/1/16
File
test/org/hibernate/shards/testmodel/replicationtest/NotReplicatedBadCascade.java
(right):

http://codereview.appspot.com/8456/diff/1/16#newcode1
Line 1: package org.hibernate.shards.testmodel.replicationtest;
apache license

http://codereview.appspot.com/8456/diff/1/16#newcode12
Line 12: * User: dantonetti
please change to match other shards source files

http://codereview.appspot.com/8456/diff/1/16#newcode19
Line 19: @Id
indentation

http://codereview.appspot.com/8456/diff/1/19
File test/org/hibernate/shards/testmodel/replicationtest/Replicated1.java
(right):

http://codereview.appspot.com/8456/diff/1/19#newcode1
Line 1: package org.hibernate.shards.testmodel.replicationtest;
apache license

http://codereview.appspot.com/8456/diff/1/19#newcode12
Line 12: * User: dantonetti
please change to match other shards source files

http://codereview.appspot.com/8456/diff/1/19#newcode20
Line 20: @Id
indentation

http://codereview.appspot.com/8456/diff/1/20
File test/org/hibernate/shards/testmodel/replicationtest/Replicated2.java
(right):

http://codereview.appspot.com/8456/diff/1/20#newcode1
Line 1: package org.hibernate.shards.testmodel.replicationtest;
apache license

http://codereview.appspot.com/8456/diff/1/20#newcode10
Line 10: * User: dantonetti
please change to match other shards source files

http://codereview.appspot.com/8456/diff/1/20#newcode19
Line 19: @Id
indentation

[danny.antonetti, 2008-11-30 02:18:25]

I have updated this change, fixing Max's comments.

This change performs a check to verify that there are no cascades from
Non-Replicated Entities to Replicated Entities.