Python/ceval.c - Issue 842: Exception state lives too long in 3.0

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
j / k :	jump to file after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue


	Comment editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Unified Diff: Python/ceval.c

Issue 842: Exception state lives too long in 3.0 (Closed) SVN Base: http://svn.python.org/view/*checkout*/python/branches/py3k/

Patch Set: Created 4 months, 1 week ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: Python/ceval.c

===================================================================

--- Python/ceval.c (revision 62647)

+++ Python/ceval.c (working copy)

@@ -1477,6 +1477,19 @@

"'finally' pops bad exception");

why = WHY_EXCEPTION;

}

+ /*

+ Make sure the exception state is cleaned up before

+ the end of an except block. This ensures objects

+ referenced by the exception state are not kept

+ alive too long.

+ See #2507.

jhylton 2008/05/06 12:59:48 We don't have a lot of comments that refer to spec

Antoine Pitrou 2008/05/06 15:19:41 On 2008/05/06 12:59:48, jhylton wrote: > We don't

+ */

Antoine Pitrou 2008/05/02 22:17:07 Hmm, it looks like I have gone past the 79-column

+ if (tstate->frame->f_exc_type != NULL)

+ reset_exc_info(tstate);

+ else {

+ assert(tstate->frame->f_exc_value == NULL);

+ assert(tstate->frame->f_exc_traceback == NULL);

jhylton 2008/05/06 12:59:48 I'd move the asserts outside of the else. They sh

Antoine Pitrou 2008/05/06 15:19:41 On 2008/05/06 12:59:48, jhylton wrote: > I'd move

+ }

Py_DECREF(v);

break;