A trivial patch to shutil.destinsrc()

shutil.destinsrc() can return wrong result if src is merely substring of destination (even though it is not a subdirectory).

This has been submitted in the tracker some time back but tracker is not accessible right now so I uploaded local patch file (I did regenerate against latest trunk).

[Benjamin, 2008-05-02 21:24:26]

http://codereview.appspot.com/841/diff/1/21
File Lib/shutil.py (right):

http://codereview.appspot.com/841/diff/1/21#newcode230
Line 230: def destinsrc(src, dst):
Since this is not a public API, shouldn't it get a "_" in front?

[Raghu, 2008-05-03 19:09:34]

http://codereview.appspot.com/841/diff/1/21
File Lib/shutil.py (right):

http://codereview.appspot.com/841/diff/1/21#newcode230
Line 230: def destinsrc(src, dst):
On 2008/05/02 21:24:26, musiccomposition wrote:
> Since this is not a public API, shouldn't it get a "_" in front?

I agree. The only reason I added test cases for this non-public API directly is
because it is very difficult to test it from within move().

[Benjamin, 2008-05-03 19:20:16]

http://codereview.appspot.com/841/diff/1/21
File Lib/shutil.py (right):

http://codereview.appspot.com/841/diff/1/21#newcode230
Line 230: def destinsrc(src, dst):
On 2008/05/03 19:09:34, draghuram wrote:
> On 2008/05/02 21:24:26, musiccomposition wrote:
> > Since this is not a public API, shouldn't it get a "_" in front?
> 
> I agree. The only reason I added test cases for this non-public API directly
is
> because it is very difficult to test it from within move(). 
> 

That's fine. You're allowed to (and should) test non-public APIs if it helps
verify the sanity of the public ones.

http://codereview.appspot.com/841/diff/1/21#newcode230
Line 230: def destinsrc(src, dst):
On 2008/05/03 19:09:34, draghuram wrote:
> On 2008/05/02 21:24:26, musiccomposition wrote:
> > Since this is not a public API, shouldn't it get a "_" in front?
> 
> I agree. The only reason I added test cases for this non-public API directly
is
> because it is very difficult to test it from within move(). 
> 

Done.

[GvR, 2008-05-05 16:58:13]

Hi draghuram, I've added wordwrap to the issue description and message body. 
Let me know if this is what you wanted.