Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2244)

Issue 840046: ns-3: Enhance WifiInformationElement and use in Wi-Fi module (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 9 months ago by Dean
Modified:
14 years, 6 months ago
Reviewers:
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

This patch builds on that captured in Issue 898045 (which is a proposed change for Bug 881 in the ns-3 Bugzilla module) to make use of the WifiInformationElement object in the wifi module. It includes some changes (improvements, I believe) to the way Serialize and Deserialize methods of a number of Wi-Fi and mesh objects work (specifically, changing to pass the iterator by reference) in order to simplify things for the caller. The Ssid and SupportedRates classes are then converted to derive from WifiInformationElement. The patch is based on ns-3-dev changeset 6194:5f8e99c4c456 as modified by the changes in Issue 898045. I've deliberately excluded the necessary updates to the python bindings from the uploaded files in order to keep the view as simple as possible.

Patch Set 1 : Enhance and use WifiInformationElement and friends #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -201 lines) Patch
M src/devices/mesh/dot11s/ie-dot11s-beacon-timing.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/devices/mesh/dot11s/ie-dot11s-beacon-timing.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M src/devices/mesh/dot11s/ie-dot11s-configuration.h View 2 chunks +5 lines, -4 lines 0 comments Download
M src/devices/mesh/dot11s/ie-dot11s-configuration.cc View 5 chunks +16 lines, -10 lines 0 comments Download
M src/devices/mesh/dot11s/ie-dot11s-id.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/devices/mesh/dot11s/ie-dot11s-id.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M src/devices/mesh/dot11s/ie-dot11s-metric-report.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/devices/mesh/dot11s/ie-dot11s-metric-report.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M src/devices/mesh/dot11s/ie-dot11s-peer-management.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/devices/mesh/dot11s/ie-dot11s-peer-management.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M src/devices/mesh/dot11s/ie-dot11s-peering-protocol.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/devices/mesh/dot11s/ie-dot11s-peering-protocol.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M src/devices/mesh/dot11s/ie-dot11s-perr.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/devices/mesh/dot11s/ie-dot11s-perr.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M src/devices/mesh/dot11s/ie-dot11s-prep.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/devices/mesh/dot11s/ie-dot11s-prep.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M src/devices/mesh/dot11s/ie-dot11s-preq.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/devices/mesh/dot11s/ie-dot11s-preq.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M src/devices/mesh/dot11s/ie-dot11s-rann.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/devices/mesh/dot11s/ie-dot11s-rann.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M src/devices/mesh/dot11s/peer-link-frame.cc View 6 chunks +5 lines, -17 lines 0 comments Download
M src/devices/mesh/mesh-information-element-vector.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/devices/wifi/capability-information.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/devices/wifi/capability-information.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M src/devices/wifi/mgt-headers.cc View 7 chunks +24 lines, -24 lines 0 comments Download
M src/devices/wifi/ssid.h View 3 chunks +7 lines, -5 lines 0 comments Download
M src/devices/wifi/ssid.cc View 2 chunks +9 lines, -29 lines 0 comments Download
M src/devices/wifi/status-code.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/devices/wifi/status-code.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M src/devices/wifi/supported-rates.h View 2 chunks +7 lines, -4 lines 0 comments Download
M src/devices/wifi/supported-rates.cc View 1 chunk +14 lines, -18 lines 0 comments Download
M src/devices/wifi/wifi-information-element.h View 1 chunk +16 lines, -3 lines 0 comments Download
M src/devices/wifi/wifi-information-element.cc View 2 chunks +49 lines, -2 lines 0 comments Download
M src/devices/wifi/wifi-information-element-vector.cc View 2 chunks +1 line, -5 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b