Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(233)

Issue 83900043: FSA Add WindowsAclFileAttributeViewsTest (Part 3) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by Brett
Modified:
10 years, 1 month ago
Reviewers:
pjo, mifern
CC:
connector-cr_google.com
Visibility:
Public.

Description

This final CL adds tests for the getShareAcl() method. I was forced to make WindowsAclFileAttributeViews.Mpr class public or jna.Native complained when I tried to create an instance of it. This CL also required adding another stub JNA implemenation of Netapi32. This brings coverage for WindowsAclFileAttributeViews up to 96% line coverage and 89% branch coverage. It brings overall coverage for the adaptor to 84% line coverage and 80% branch coverage.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+420 lines, -27 lines) Patch
M src/com/google/enterprise/adaptor/fs/WindowsAclFileAttributeViews.java View 1 chunk +1 line, -1 line 0 comments Download
A test/com/google/enterprise/adaptor/fs/UnsupportedNetapi32.java View 1 chunk +153 lines, -0 lines 0 comments Download
M test/com/google/enterprise/adaptor/fs/WindowsAclFileAttributeViewsTest.java View 5 chunks +266 lines, -26 lines 0 comments Download

Messages

Total messages: 3
Brett
10 years, 1 month ago (2014-04-03 07:44:46 UTC) #1
pjo
Thank you. LGTM. Miguel, any thoughts? Yey >80% branch!
10 years, 1 month ago (2014-04-03 22:24:31 UTC) #2
Brett
10 years, 1 month ago (2014-04-04 01:27:04 UTC) #3
Committed 03 April 2014 to File System Adaptor:
To https://code.google.com/p/plexi.fs/
   9d6c118..22b6a21  master -> master
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b