Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(112)

Issue 8384043: doc: explain how to add lyrics to polyphonic sections (issue 3236)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 12 months ago by janek
Modified:
10 years, 11 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

doc: explain how to add lyrics to polyphonic sections (issue 3236)

Patch Set 1 #

Total comments: 4

Patch Set 2 : reduce as Trevor suggested #

Patch Set 3 : fix typo #

Total comments: 2

Patch Set 4 : nitpicks #

Total comments: 5

Patch Set 5 : correct references #

Total comments: 4

Patch Set 6 : remove space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M Documentation/notation/vocal.itely View 1 2 3 4 5 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 28
pkx166h
https://codereview.appspot.com/8384043/diff/1/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right): https://codereview.appspot.com/8384043/diff/1/Documentation/notation/vocal.itely#newcode1632 Documentation/notation/vocal.itely:1632: cadence, or a measure or two. The @code{<< {...} ...
10 years, 12 months ago (2013-04-04 21:38:15 UTC) #1
Trevor Daniels
This expresses pretty much what already appears under Temporary polyphonic passages in Section 1.5.2 of ...
10 years, 12 months ago (2013-04-04 22:03:52 UTC) #2
Jean-Charles
Typo https://codereview.appspot.com/8384043/diff/1/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right): https://codereview.appspot.com/8384043/diff/1/Documentation/notation/vocal.itely#newcode1637 Documentation/notation/vocal.itely:1637: contexts} which will result in @emph{no lyrcis} being ...
10 years, 12 months ago (2013-04-05 06:58:21 UTC) #3
jimmyg521
A proposal: given that no other section of 1.5.2 mentions lyrics, perhaps using my submission ...
10 years, 11 months ago (2013-04-06 18:15:15 UTC) #4
Trevor Daniels
The section at 1.5.2 on Single-staff polyphony forms a unified whole and needs to remain ...
10 years, 11 months ago (2013-04-07 19:12:46 UTC) #5
janek
reduce as Trevor suggested
10 years, 11 months ago (2013-04-09 21:08:39 UTC) #6
janek
fix typo
10 years, 11 months ago (2013-04-09 21:10:35 UTC) #7
janek
Changed as suggested. Janek https://codereview.appspot.com/8384043/diff/1/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right): https://codereview.appspot.com/8384043/diff/1/Documentation/notation/vocal.itely#newcode1632 Documentation/notation/vocal.itely:1632: cadence, or a measure or ...
10 years, 11 months ago (2013-04-09 21:11:11 UTC) #8
Trevor Daniels
A couple of minor suggestions, otherwise LGTM Thanks, Janek! Trevor https://codereview.appspot.com/8384043/diff/10001/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right): https://codereview.appspot.com/8384043/diff/10001/Documentation/notation/vocal.itely#newcode1632 ...
10 years, 11 months ago (2013-04-09 21:26:38 UTC) #9
janek
nitpicks
10 years, 11 months ago (2013-04-09 21:35:55 UTC) #10
janek
done. https://codereview.appspot.com/8384043/diff/10001/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right): https://codereview.appspot.com/8384043/diff/10001/Documentation/notation/vocal.itely#newcode1632 Documentation/notation/vocal.itely:1632: cadence, or a measure or two. The @code{<< ...
10 years, 11 months ago (2013-04-09 21:36:27 UTC) #11
pkx166h
fails make https://codereview.appspot.com/8384043/diff/15001/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right): https://codereview.appspot.com/8384043/diff/15001/Documentation/notation/vocal.itely#newcode1641 Documentation/notation/vocal.itely:1641: @ref{Temporary polyphonic passages}. Fails make "Cross reference ...
10 years, 11 months ago (2013-04-10 03:25:30 UTC) #12
janek
https://codereview.appspot.com/8384043/diff/15001/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right): https://codereview.appspot.com/8384043/diff/15001/Documentation/notation/vocal.itely#newcode1641 Documentation/notation/vocal.itely:1641: @ref{Temporary polyphonic passages}. On 2013/04/10 03:25:30, J_lowe wrote: > ...
10 years, 11 months ago (2013-04-10 06:50:59 UTC) #13
dak
On 2013/04/10 06:50:59, janek wrote: > https://codereview.appspot.com/8384043/diff/15001/Documentation/notation/vocal.itely > File Documentation/notation/vocal.itely (right): > > https://codereview.appspot.com/8384043/diff/15001/Documentation/notation/vocal.itely#newcode1641 > ...
10 years, 11 months ago (2013-04-10 07:06:47 UTC) #14
Trevor Daniels
On 2013/04/10 06:50:59, janek wrote: > Hmm, so i'd have to ref "Single-staff polyphony" which ...
10 years, 11 months ago (2013-04-10 07:58:57 UTC) #15
janek
correct references
10 years, 11 months ago (2013-04-10 08:05:56 UTC) #16
janek
On 2013/04/10 07:06:47, dak wrote: > On 2013/04/10 06:50:59, janek wrote: > > Hmm, so ...
10 years, 11 months ago (2013-04-10 08:14:43 UTC) #17
pkx166h
nearly there https://codereview.appspot.com/8384043/diff/23001/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right): https://codereview.appspot.com/8384043/diff/23001/Documentation/notation/vocal.itely#newcode1641 Documentation/notation/vocal.itely:1641: @emph {Temporary polyphonic passages} in @ref{Single-staff polyphony}. ...
10 years, 11 months ago (2013-04-10 10:40:58 UTC) #18
janek
remove space
10 years, 11 months ago (2013-04-10 10:43:23 UTC) #19
janek
bang. that's why i don't like writing docs - i don't remember the syntax :) ...
10 years, 11 months ago (2013-04-10 10:45:29 UTC) #20
dak
On 2013/04/10 10:45:29, janek wrote: > bang. > that's why i don't like writing docs ...
10 years, 11 months ago (2013-04-10 11:00:25 UTC) #21
janek
2013/4/10 <dak@gnu.org>: > On 2013/04/10 10:45:29, janek wrote: >> >> bang. >> that's why i ...
10 years, 11 months ago (2013-04-10 11:06:16 UTC) #22
wl_gnu.org
> that's why i don't like writing docs - i don't remember the syntax > ...
10 years, 11 months ago (2013-04-10 11:06:20 UTC) #23
janek
2013/4/10 Werner LEMBERG <wl@gnu.org>: > >> that's why i don't like writing docs - i ...
10 years, 11 months ago (2013-04-10 11:12:12 UTC) #24
dak
Janek Warchoł <janek.lilypond@gmail.com> writes: > 2013/4/10 Werner LEMBERG <wl@gnu.org>: >> >>> that's why i don't ...
10 years, 11 months ago (2013-04-10 11:17:41 UTC) #25
wl_gnu.org
> But when i'm editing Wikipedia, i have syntax buttons next to me, > and ...
10 years, 11 months ago (2013-04-10 11:19:16 UTC) #26
janek
2013/4/10 David Kastrup <dak@gnu.org> > > Janek Warchoł <janek.lilypond@gmail.com> writes: > > Of course not! ...
10 years, 11 months ago (2013-04-10 22:28:24 UTC) #27
Graham Percival
10 years, 11 months ago (2013-04-11 22:38:40 UTC) #28
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b