Issue 838042: new subsurface closure

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 838042: new subsurface closure (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by ckulla

Modified:
14 years ago

Reviewers:
dev-osl, osl-dev, aconty

Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Adds a new closure that holds the real volumetric properties of a homogeneous medium. This isn't quite what is intended for volume support in OSL but fills a gap in the meantime that lets us do SSS volumetrically in certain cases. The closure is parameterized based on Jensen's hierarchical BSSRDF paper.

Patch Set 1 #

Patch Set 2 : It would help to include the actual implementation of the new closure ... #

Created: 14 years ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+171 lines, -2 lines)			Patch
src/include/oslclosure.h	View	3 chunks	+35 lines, -1 line	0 comments	Download
src/liboslcomp/typecheck.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
src/liboslexec/CMakeLists.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
src/liboslexec/master.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
src/liboslexec/oslops.h	View	1 chunk	+1 line, -1 line	0 comments	Download
src/liboslexec/vol_subsurface.cpp	View	1 chunk	+132 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ckulla

It would help to include the actual implementation of the new closure ...

14 years ago (2010-03-29 22:09:10 UTC) #2

LGTM

Expand All Messages | Collapse All Messages