Issue 838041: Moved code to unmangle function name to a common place and used it in both Ou...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 838041: Moved code to unmangle function name to a common place and used it in both Ou... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by Alok Priyadarshi

Modified:
15 years, 4 months ago

Reviewers:
vangelis, dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Moved code to unmangle function name to a common place and used it in both OutputGLSL and OutputHLSL.

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -51 lines)			Patch
M	src/compiler/OutputGLSL.cpp	View	3 chunks	+2 lines, -7 lines	0 comments	Download
M	src/compiler/OutputHLSL.cpp	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/compiler/SymbolTable.h	View	13 chunks	+50 lines, -40 lines	0 comments	Download

Total messages: 3

dgkoch

15 years, 4 months ago (2010-03-29 23:27:52 UTC) #3

Approved.

In general I'd prefer to keep function changes in separate patches from
formatting/whitespace changes though.