Issue 8310043: Define call-after-session for cleanup called after every file

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8310043: Define call-after-session for cleanup called after every file (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by dak

Modified:
11 years ago

Reviewers:
Ian Hulin (gmail), lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Define call-after-session for cleanup called after every file Also has the two commits: Use call-after-session to clear out hashes per session at an obvious place. Issue 3283: Stop table of contents bleedover

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -6 lines)			Patch
M	ly/declarations-init.ly	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	ly/init.ly	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	ly/toc-init.ly	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	scm/lily.scm	View	2 chunks	+11 lines, -3 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Ian Hulin (gmail)

11 years, 1 month ago (2013-04-03 22:39:39 UTC) #2

LGTM.
You've done a load of good work on introducing the session architecture, so why
not let people know about it, even if it's only via a comment in lily.scm?

Cheers,
Ian

https://codereview.appspot.com/8310043/diff/1/scm/lily.scm
File scm/lily.scm (right):

https://codereview.appspot.com/8310043/diff/1/scm/lily.scm#newcode45
scm/lily.scm:45: 
;;
;; Session-handling variables and procedures.
;;
;;  Sessions are used to ensure that environments are kept 
;;  separate when LilyPond is called to compile several 
;;  files on the command line, and there is no 'bleed-over' 
;;  between the source files
;;

Expand All Messages | Collapse All Messages