set invoice date when invoice is opened

closed

[ced1, 2009-06-20 16:21:23]

You should also fix set_number perhaps it is there that we must write
invoice_date if needed.
copy must also be adapted.

http://codereview.appspot.com/83045/diff/1/3
File invoice.py (right):

http://codereview.appspot.com/83045/diff/1/3#newcode53
Line 53: invoice_date = fields.Date('Invoice Date', states=_STATES)
You should add a required states for at least the status open

http://codereview.appspot.com/83045/diff/1/3#newcode850
Line 850: 'invoice_date': invoice_date,
You should not write invoice_date if it is not necessary

[yangoon1, 2009-06-23 10:19:14]

Just for my information:

Which is the preferred method to set actual date?
The current patch uses ir.date object, but for instance stock/packing.py uses
datetime.date.today() directly. So probably stock/packing.py should be fixed...?

[ced1, 2009-06-23 10:40:41]

I think the report must also be fixed.

http://codereview.appspot.com/83045/diff/7/9
File invoice.py (right):

http://codereview.appspot.com/83045/diff/7/9#newcode55
Line 55: 'readonly': "state != 'draft'",
Why not also for proforma?

http://codereview.appspot.com/83045/diff/7/9#newcode887
Line 887: self.write(cursor, user, invoice.id, {
It is  better to have only one call to write and fill a dict with values.

http://codereview.appspot.com/83045/diff/7/9#newcode889
Line 889: 'invoice_date': date_obj.today(cursor, user, context=context),
Why calling twice today?

[yangoon1, 2009-06-23 10:50:36]

Just a proposal to have self.write only written once

http://codereview.appspot.com/83045/diff/7/9
File invoice.py (right):

http://codereview.appspot.com/83045/diff/7/9#newcode882
Line 882: if invoice.invoice_date:
Wouldn't it be a little bit nicer to have:

vals = {'number': number}
if not invoice.invoice_date:
    vals['invoice_date'] = ctx['date']
self.write(cursor, user, invoice.id, vals, context=context)

[yangoon1, 2009-06-23 10:53:22]

On 2009/06/23 10:50:36, yangoon wrote:

Sorry, just see now that meanwhile just those comments were added...

> Just a proposal to have self.write only written once
> 
> http://codereview.appspot.com/83045/diff/7/9
> File invoice.py (right):
> 
> http://codereview.appspot.com/83045/diff/7/9#newcode882
> Line 882: if invoice.invoice_date:
> Wouldn't it be a little bit nicer to have:
> 
> vals = {'number': number}
> if not invoice.invoice_date:
>     vals['invoice_date'] = ctx['date']
> self.write(cursor, user, invoice.id, vals, context=context)

[ced1, 2009-07-01 13:53:08]

I can not review the odt file.

http://codereview.appspot.com/83045/diff/3002/3005
File invoice.py (right):

http://codereview.appspot.com/83045/diff/3002/3005#newcode55
Line 55: 'readonly': "state not in ('draft','proforma')",
I think it is better to have the opposite form:
"state in ('open', 'paid')"

http://codereview.appspot.com/83045/diff/3002/3005#newcode56
Line 56: 'required': "state == 'open'",
Also for paid

[ced1, 2009-07-16 15:36:00]

Looks ok now.
You can add the hg patch on roundup.

[ced1, 2009-07-23 08:54:57]

Can be closed