Issue 8258043: Carry any exports from session initialization over to subsequent sessions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8258043: Carry any exports from session initialization over to subsequent sessions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by dak

Modified:
11 years ago

Reviewers:
janek, Ian Hulin (gmail)

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Carry any exports from session initialization over to subsequent sessions When a .ly file in the session initialization loaded a module, this module's exports were only available in the first session on the command line. This patch causes any modules available after first session initialization to be available in subsequent sessions.

Patch Set 1 #

Total comments: 2

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	scm/lily.scm	View		3 chunks	+6 lines, -0 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Ian Hulin (gmail)

11 years ago (2013-04-11 14:35:45 UTC) #2

LGTM
The comments contain some Scheme comments to help hackers find their way around
a bit in lily.scm.
Lily.scm is getting a bit unwieldy and untidy - maybe give it a spring-clean in
a future tracker?

https://codereview.appspot.com/8258043/diff/1/scm/lily.scm
File scm/lily.scm (right):

https://codereview.appspot.com/8258043/diff/1/scm/lily.scm#newcode45
scm/lily.scm:45: 
;;
;; Sessions
;;    Variables and procedures supporting sessions
;;    (see doc-string for define-session
;;

https://codereview.appspot.com/8258043/diff/1/scm/lily.scm#newcode128
scm/lily.scm:128: 
;;
;; Command-line options (long and short form)
;;
;;

Expand All Messages | Collapse All Messages