Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7982)

Issue 82420045: More readable \displayMusic output.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by Devon Schudy
Modified:
10 years, 1 month ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

More readable \displayMusic output. * Omit unnecessary optional arguments. * Use rationals when printing moments (but not with grace parts, because that's ambiguous). It would be nice to make the pretty-printed output smarter about newlines too, e.g: (make-music 'NoteEvent 'duration (ly:make-duration 2) 'pitch (ly:make-pitch 2 3)) ...but the ice-9 pretty-printer isn't customizable without shipping a modified copy. I don't think it's worth the bother.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix durations. Print negative graces as rationals. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M scm/music-functions.scm View 1 2 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 3
dak
https://codereview.appspot.com/82420045/diff/1/scm/music-functions.scm File scm/music-functions.scm (right): https://codereview.appspot.com/82420045/diff/1/scm/music-functions.scm#newcode181 scm/music-functions.scm:181: (list (ly:moment-main obj)) Two-argument form is not really ambiguous: ...
10 years, 1 month ago (2014-03-31 05:58:33 UTC) #1
Devon Schudy
Fix durations. Print negative graces as rationals.
10 years, 1 month ago (2014-03-31 14:42:26 UTC) #2
dak
10 years, 1 month ago (2014-03-31 15:07:34 UTC) #3
On 2014/03/31 14:42:26, Devon Schudy wrote:
> Fix durations. Print negative graces as rationals.

Looks good.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b