Melange Surveys: New and updated JS and CSS 'upstream' files.

[Mario Ferraro, 2009-06-21 10:35:47]

All should be moved in the right directories (following current naming path),
and also don't use packed versions for repository (I'll enhance build.sh to use
shrinksafe for packing when releasing).

Cheers :)

http://codereview.appspot.com/82041/diff/1/4
File app/soc/content/js/jquery.editable-1.3.3.js (right):

http://codereview.appspot.com/82041/diff/1/4#newcode1
Line 1: (function($){
This file should be in app/jquery directory with name jquery-editable-1.3.3.js

http://codereview.appspot.com/82041/diff/1/5
File app/soc/content/js/jquery.growfield.packed-trunk.js (right):

http://codereview.appspot.com/82041/diff/1/5#newcode1
Line 1:
eval(function(p,a,c,k,e,r){e=function(c){return(c<a?'':e(parseInt(c/a)))+((c=c%a)>35?String.fromCharCode(c+29):c.toString(36))};if(!''.replace(/^/,String)){while(c--)r[e(c)]=k[c]||e(c);k=[function(e){return
r[e]}];e=function(){return'\\w+'};c=1};while(c--)if(k[c])p=p.replace(new
RegExp('\\b'+e(c)+'\\b','g'),k[c]);return
p}('(7($){4($.1i===1j){$.1i={1k:$.1k}}5
v=6;$(1z).1A(\'1B\',7(){v=C});$.O.Z.1C=$.O.Z.F;$.O.Z.F=6;$.O.Z.F=7(){4(!3.1l.1D){D
3.1C.1E(3)}4(3.1l.K){3.1l.K.1E(3.24,3.25,3)}(1m.O.K[3.26]||1m.O.K.27)(3)};$.8=7(a,b){5
c=$.1n({1F:a,o:$(a),R:6,B:6,P:6,11:6,28:6,12:6,13:6,1o:6,z:$.1n({},$.S.8.1G,b)},$.8.1H);D
c};$.8.1H=(7(){5 l=7(e){5
a=e.w;4(e.29&&(e.14==1p||e.14==1I)){a.F(a.o.2a()+(a.z.K*(e.14==1p?-1:1)),a.z.J)}};5
m=7(e){5 a=e.w;4(!a.P){4($.2b(e.14,[2c,1p,2d,1I])===-1){a.F(a.15(),a.z.J)}}D
C};5 n=7(e){5 a=e.w;4(!a.P){4(a.z.L){a.F(a.B?a.15():a.1o,a.z.J,\'1q\')}}};5
p=7(e){5 a=e.w;4(!a.P){4(a.z.L){a.F(0,a.z.J,\'L\')}}};5 q=7(e){5 a=e.w;5 o=a.o;5
b=a.z;4(!b.G){b.G=E(o.9(\'G-H\'),10)||a.13||E(o.H(),10)||20;4(b.G<=0){b.G=20}4(!a.13){a.13=b.G}}4(!b.x){b.x=E(o.9(\'x-H\'),10)||6;4(b.x<=0){b.x=6}}4(!b.K){b.K=E(o.9(\'2e-H\'),10)||E(o.9(\'2f-2g\'),10)||20}5
c={1J:E(o.9(\'2h\'),10)||0,1K:E(o.9(\'2i\'),10)||0,1L:E(o.9(\'2j\'),10)||0,1M:E(o.9(\'2k\'),10)||0,T:E(o.9(\'2l\'),10)||6,Q:E(o.9(\'2m\'),10)||6};a.16=c};5
r=7(e){5 a=e.w;4(!a.B){5 b=a.o.U();5
c=a.o.2n();c.2o(\'1N\');c.2p(\'2q\',-1O);c.9({2r:\'2s\',2t:-1O,2u:0,H:\'2v\',17:\'1P\'});c.2w(a.o);c.2x();4(!b){c.U(\'B
2y\')}a.B=c;a.F((!$.2z(b)||a.z.L)?0:a.15(),6)}};5
s=7(e){18=e.w;4(18.B){18.B.2A();2B 18.B}};5
t=7(a,b){4(a.o.H()!==0||v){$(2C).2D(7(){b({w:a})})}M{$(1z).1A(\'1B\',a,b)}};5
u={1Q:7(a){4((a==\'1R\'||a===6)&&3.R){3.V()}M
4((a==\'1S\'||a===C)&&!3.R){3.A()}D 3},A:7(){t(3,q);5 a=3.z;5
o=3.o;4(a.N){o.A(\'2E.8\',3,m);3.11={I:3.o.9(\'I\'),1T:3.o.9(\'17\')};4($.19.1r){o.9(\'17\',\'1P\')}o.9(\'I\',\'1s\');o.A(\'W.8\',3,r);t(3,r);t(3,s)}M{o.A(\'2F.8\',3,l);o.9(\'I-y\',\'N\');t(3,7(e){e.w.F(e.w.o.H())})}o.A(\'W.8\',3,n);o.A(\'1U.8\',3,p);o.A(\'1U.8\',3,s);4(a.1a){o.A(\'1a.8\',a.1a)}4(a.1b){o.A(\'1b.8\',a.1b)}4(a.1c){o.A(\'1c.8\',a.1c)}3.R=C;D
3},V:7(){s({w:3});3.o.V(\'.8\');3.o.9(\'I\',3.11.I);4($.19.1r){3.o.9(\'17\',3.11.1T)}3.R=6;D
3},1t:7(a){5
o=3.o;o.1u(\'1a.8\');4(a==\'L\'){o.1u(\'1b.8\')}4(a==\'1q\'){o.1u(\'1c.8\')}},F:7(h,a,b){5
c=3.16;5 d=3.o.U();5 e=3.z;5 f=3.1F;5 o=3.o;5 g=3;5 i=3.12;5 j=!e.N;5
k=e.N;h=3.1v(2G.2H(h),\'1V\');h=e.G>h?e.G:e.x&&h>e.x?e.x:e.N&&!d?e.G:h;4(e.x&&e.N){4(i!=e.x&&h==e.x){o.9(\'I-y\',\'2I\');4(!e.J){o.W()}j=C;k=6}4(i==e.x&&h<e.x){o.9(\'I-y\',\'1s\');4(!e.J){o.W()}k=6}}4(h==i){D
C}4(!e.N&&b==\'L\'){3.1o=3.1v(3.12,\'2J\')}3.12=h;4(a){g.P=C;o.J({H:h},{2K:e.J,1d:($.1d?e.1d:1w),I:1w,1D:C,2L:7(){4(!j){o.9(\'I\',\'1s\')}4(!k&&b!=\'L\'){o.W()}4(b==\'1q\'){f.2M=f.1x}g.P=6;g.1t(b)},2N:6})}M{f.1W.H=h+\'1X\';3.1t(b)}},15:7(){5
a=3.o.U();5 h=0;5 b=3.16;5
c="\\1Y\\1Y";4($.19.1r){a=a.2O(0,a.2P-1)}4(!b.T||!b.Q){a+=c}3.B.U(a);4($.19.2Q){3.B[0].1W.H=3.B[0].1x+\'1X\'}h=3.B[0].1x;4(b.T&&b.Q){h+=b.T>b.Q?b.T+b.Q:b.Q*2}D
h},1v:7(h,a){5 b=3.16,X=(a==\'1V\'?-1:1),Y=$.1i.1k;D
h+(Y?b.1L:0)*X+(Y?b.1M:0)*X+(Y?b.1J:0)*X+(Y?b.1K:0)*X}};D
u})();$.S.8=7(c){2R(c){1Z\'1S\':c=C;21;1Z\'1R\':c=6;21}5 d=2S c;5
e={1y:d==\'2T\',1e:d==\'1e\',1f:d==\'1f\',1g:c==\'1g\',1h:c==\'1h\'};4(e.1e&&!e.1h&&!e.1g){c=$.S.8.22[c];e.1e=6;e.1f=C}4(e.1h){3.23(7(){5
a=$(3);5 b=a.w(\'8\');4(b!==1j){b.V();a.2U(\'8\')}})}M{5
f=/2V/i;3.23(7(){4(f.2W(3.2X)&&!$(3).2Y(\'1N\')){5 o=$(3);5
a=o.w(\'8\');4(a===1j){a=$.8(3,c);o.w(\'8\',a);4(!e.1y||c){a.A()}}M{4(e.1f&&c){$.1n(a.z,c)}M
4(e.1y){a.1Q(c)}M 4(e.1g){a.V();a.A()}}}})}D
3};$.S.8.1G={N:C,J:2Z,1d:1w,G:6,x:6,L:6,K:6};$.S.8.22={}})(1m);',62,186,'|||this|if|var|false|function|growfield|css|||||||||||||||||||||||data|max||opt|bind|dummy|true|return|parseInt|update|min|height|overflow|animate|step|restore|else|auto|fx|busy|fs|enabled|fn|lh|val|unbind|focus|mod|bm|prototype||initial|prevH|firstH|keyCode|getDummyHeight|sizeRelated|resize|obj|browser|onHeightChange|onRestore|onGrowBack|easing|string|object|restart|destroy|support|undefined|boxModel|options|jQuery|extend|restoreH|38|growback|safari|hidden|triggerEvents|trigger|convertHeight|null|scrollHeight|bool|window|one|load|originalUpdate|inline|call|dom|defaults|ptt|40|pt|pb|bt|bb|growfieldDummy|9999|none|toggle|disable|enable|cssResize|blur|inner|style|px|n111|case||break|presets|each|elem|now|prop|_default|sizseRelated|ctrlKey|outerHeight|inArray|37|39|line|font|size|paddingTop|paddingBottom|borderTopWidth|borderBottomWidth|lineHeight|fontSize|clone|addClass|attr|tabindex|position|absolute|left|top|20px|insertAfter|show|text|trim|remove|delete|document|ready|keyup|keydown|Math|round|scroll|outer|duration|complete|scrollTop|queue|substring|length|msie|switch|typeof|boolean|removeData|textarea|test|tagName|hasClass|100'.split('|'),0,{}))


This file should be in app/jquery directory with name jquery-growfield.js Also I
think it should not be packed. We would like to keep third party JS files
unpacked (so we can read the code and eventually patch it) and then pack them in
the release script with Shrinksafe

http://codereview.appspot.com/82041/diff/1/6
File app/soc/content/js/ui.dialog.js (right):

http://codereview.appspot.com/82041/diff/1/6#newcode1
Line 1: /*
This file should be in app/jquery directory with name jquery-ui.dialog.js

http://codereview.appspot.com/82041/diff/1/7
File app/soc/content/js/ui.draggable.js (right):

http://codereview.appspot.com/82041/diff/1/7#newcode1
Line 1: /*
This file should be in app/jquery directory with name jquery-ui.draggable.js

http://codereview.appspot.com/82041/diff/1/8
File app/soc/content/js/ui.sortable.js (right):

http://codereview.appspot.com/82041/diff/1/8#newcode1
Line 1: /*
This file should be in app/jquery directory with name jquery-ui.sortable.js

[ajaksu, 2009-06-21 20:48:55]

Thanks a lot for the review, Mario!

On 2009/06/21 10:35:47, Mario Ferraro wrote:
> All should be moved in the right directories (following current naming path),
> and also don't use packed versions for repository (I'll enhance build.sh to
use
> shrinksafe for packing when releasing).
> 

Great, thanks :)

What do you think about adding version info to jquery.growfield? (BTW, -editable
and .growfield?).

http://codereview.appspot.com/82041/diff/1/4
File app/soc/content/js/jquery.editable-1.3.3.js (right):

http://codereview.appspot.com/82041/diff/1/4#newcode1
Line 1: (function($){
On 2009/06/21 10:35:47, Mario Ferraro wrote:
> This file should be in app/jquery directory with name jquery-editable-1.3.3.js

Done.

http://codereview.appspot.com/82041/diff/1/5
File app/soc/content/js/jquery.growfield.packed-trunk.js (right):

http://codereview.appspot.com/82041/diff/1/5#newcode1
Line 1:
eval(function(p,a,c,k,e,r){e=function(c){return(c<a?'':e(parseInt(c/a)))+((c=c%a)>35?String.fromCharCode(c+29):c.toString(36))};if(!''.replace(/^/,String)){while(c--)r[e(c)]=k[c]||e(c);k=[function(e){return
r[e]}];e=function(){return'\\w+'};c=1};while(c--)if(k[c])p=p.replace(new
RegExp('\\b'+e(c)+'\\b','g'),k[c]);return
p}('(7($){4($.1i===1j){$.1i={1k:$.1k}}5
v=6;$(1z).1A(\'1B\',7(){v=C});$.O.Z.1C=$.O.Z.F;$.O.Z.F=6;$.O.Z.F=7(){4(!3.1l.1D){D
3.1C.1E(3)}4(3.1l.K){3.1l.K.1E(3.24,3.25,3)}(1m.O.K[3.26]||1m.O.K.27)(3)};$.8=7(a,b){5
c=$.1n({1F:a,o:$(a),R:6,B:6,P:6,11:6,28:6,12:6,13:6,1o:6,z:$.1n({},$.S.8.1G,b)},$.8.1H);D
c};$.8.1H=(7(){5 l=7(e){5
a=e.w;4(e.29&&(e.14==1p||e.14==1I)){a.F(a.o.2a()+(a.z.K*(e.14==1p?-1:1)),a.z.J)}};5
m=7(e){5 a=e.w;4(!a.P){4($.2b(e.14,[2c,1p,2d,1I])===-1){a.F(a.15(),a.z.J)}}D
C};5 n=7(e){5 a=e.w;4(!a.P){4(a.z.L){a.F(a.B?a.15():a.1o,a.z.J,\'1q\')}}};5
p=7(e){5 a=e.w;4(!a.P){4(a.z.L){a.F(0,a.z.J,\'L\')}}};5 q=7(e){5 a=e.w;5 o=a.o;5
b=a.z;4(!b.G){b.G=E(o.9(\'G-H\'),10)||a.13||E(o.H(),10)||20;4(b.G<=0){b.G=20}4(!a.13){a.13=b.G}}4(!b.x){b.x=E(o.9(\'x-H\'),10)||6;4(b.x<=0){b.x=6}}4(!b.K){b.K=E(o.9(\'2e-H\'),10)||E(o.9(\'2f-2g\'),10)||20}5
c={1J:E(o.9(\'2h\'),10)||0,1K:E(o.9(\'2i\'),10)||0,1L:E(o.9(\'2j\'),10)||0,1M:E(o.9(\'2k\'),10)||0,T:E(o.9(\'2l\'),10)||6,Q:E(o.9(\'2m\'),10)||6};a.16=c};5
r=7(e){5 a=e.w;4(!a.B){5 b=a.o.U();5
c=a.o.2n();c.2o(\'1N\');c.2p(\'2q\',-1O);c.9({2r:\'2s\',2t:-1O,2u:0,H:\'2v\',17:\'1P\'});c.2w(a.o);c.2x();4(!b){c.U(\'B
2y\')}a.B=c;a.F((!$.2z(b)||a.z.L)?0:a.15(),6)}};5
s=7(e){18=e.w;4(18.B){18.B.2A();2B 18.B}};5
t=7(a,b){4(a.o.H()!==0||v){$(2C).2D(7(){b({w:a})})}M{$(1z).1A(\'1B\',a,b)}};5
u={1Q:7(a){4((a==\'1R\'||a===6)&&3.R){3.V()}M
4((a==\'1S\'||a===C)&&!3.R){3.A()}D 3},A:7(){t(3,q);5 a=3.z;5
o=3.o;4(a.N){o.A(\'2E.8\',3,m);3.11={I:3.o.9(\'I\'),1T:3.o.9(\'17\')};4($.19.1r){o.9(\'17\',\'1P\')}o.9(\'I\',\'1s\');o.A(\'W.8\',3,r);t(3,r);t(3,s)}M{o.A(\'2F.8\',3,l);o.9(\'I-y\',\'N\');t(3,7(e){e.w.F(e.w.o.H())})}o.A(\'W.8\',3,n);o.A(\'1U.8\',3,p);o.A(\'1U.8\',3,s);4(a.1a){o.A(\'1a.8\',a.1a)}4(a.1b){o.A(\'1b.8\',a.1b)}4(a.1c){o.A(\'1c.8\',a.1c)}3.R=C;D
3},V:7(){s({w:3});3.o.V(\'.8\');3.o.9(\'I\',3.11.I);4($.19.1r){3.o.9(\'17\',3.11.1T)}3.R=6;D
3},1t:7(a){5
o=3.o;o.1u(\'1a.8\');4(a==\'L\'){o.1u(\'1b.8\')}4(a==\'1q\'){o.1u(\'1c.8\')}},F:7(h,a,b){5
c=3.16;5 d=3.o.U();5 e=3.z;5 f=3.1F;5 o=3.o;5 g=3;5 i=3.12;5 j=!e.N;5
k=e.N;h=3.1v(2G.2H(h),\'1V\');h=e.G>h?e.G:e.x&&h>e.x?e.x:e.N&&!d?e.G:h;4(e.x&&e.N){4(i!=e.x&&h==e.x){o.9(\'I-y\',\'2I\');4(!e.J){o.W()}j=C;k=6}4(i==e.x&&h<e.x){o.9(\'I-y\',\'1s\');4(!e.J){o.W()}k=6}}4(h==i){D
C}4(!e.N&&b==\'L\'){3.1o=3.1v(3.12,\'2J\')}3.12=h;4(a){g.P=C;o.J({H:h},{2K:e.J,1d:($.1d?e.1d:1w),I:1w,1D:C,2L:7(){4(!j){o.9(\'I\',\'1s\')}4(!k&&b!=\'L\'){o.W()}4(b==\'1q\'){f.2M=f.1x}g.P=6;g.1t(b)},2N:6})}M{f.1W.H=h+\'1X\';3.1t(b)}},15:7(){5
a=3.o.U();5 h=0;5 b=3.16;5
c="\\1Y\\1Y";4($.19.1r){a=a.2O(0,a.2P-1)}4(!b.T||!b.Q){a+=c}3.B.U(a);4($.19.2Q){3.B[0].1W.H=3.B[0].1x+\'1X\'}h=3.B[0].1x;4(b.T&&b.Q){h+=b.T>b.Q?b.T+b.Q:b.Q*2}D
h},1v:7(h,a){5 b=3.16,X=(a==\'1V\'?-1:1),Y=$.1i.1k;D
h+(Y?b.1L:0)*X+(Y?b.1M:0)*X+(Y?b.1J:0)*X+(Y?b.1K:0)*X}};D
u})();$.S.8=7(c){2R(c){1Z\'1S\':c=C;21;1Z\'1R\':c=6;21}5 d=2S c;5
e={1y:d==\'2T\',1e:d==\'1e\',1f:d==\'1f\',1g:c==\'1g\',1h:c==\'1h\'};4(e.1e&&!e.1h&&!e.1g){c=$.S.8.22[c];e.1e=6;e.1f=C}4(e.1h){3.23(7(){5
a=$(3);5 b=a.w(\'8\');4(b!==1j){b.V();a.2U(\'8\')}})}M{5
f=/2V/i;3.23(7(){4(f.2W(3.2X)&&!$(3).2Y(\'1N\')){5 o=$(3);5
a=o.w(\'8\');4(a===1j){a=$.8(3,c);o.w(\'8\',a);4(!e.1y||c){a.A()}}M{4(e.1f&&c){$.1n(a.z,c)}M
4(e.1y){a.1Q(c)}M 4(e.1g){a.V();a.A()}}}})}D
3};$.S.8.1G={N:C,J:2Z,1d:1w,G:6,x:6,L:6,K:6};$.S.8.22={}})(1m);',62,186,'|||this|if|var|false|function|growfield|css|||||||||||||||||||||||data|max||opt|bind|dummy|true|return|parseInt|update|min|height|overflow|animate|step|restore|else|auto|fx|busy|fs|enabled|fn|lh|val|unbind|focus|mod|bm|prototype||initial|prevH|firstH|keyCode|getDummyHeight|sizeRelated|resize|obj|browser|onHeightChange|onRestore|onGrowBack|easing|string|object|restart|destroy|support|undefined|boxModel|options|jQuery|extend|restoreH|38|growback|safari|hidden|triggerEvents|trigger|convertHeight|null|scrollHeight|bool|window|one|load|originalUpdate|inline|call|dom|defaults|ptt|40|pt|pb|bt|bb|growfieldDummy|9999|none|toggle|disable|enable|cssResize|blur|inner|style|px|n111|case||break|presets|each|elem|now|prop|_default|sizseRelated|ctrlKey|outerHeight|inArray|37|39|line|font|size|paddingTop|paddingBottom|borderTopWidth|borderBottomWidth|lineHeight|fontSize|clone|addClass|attr|tabindex|position|absolute|left|top|20px|insertAfter|show|text|trim|remove|delete|document|ready|keyup|keydown|Math|round|scroll|outer|duration|complete|scrollTop|queue|substring|length|msie|switch|typeof|boolean|removeData|textarea|test|tagName|hasClass|100'.split('|'),0,{}))
On 2009/06/21 10:35:47, Mario Ferraro wrote:
> 
> 
> This file should be in app/jquery directory with name jquery-growfield.js Also
I
> think it should not be packed. We would like to keep third party JS files
> unpacked (so we can read the code and eventually patch it) and then pack them
in
> the release script with Shrinksafe

Agreed. Replaced by unpacked named jquery-growfield.js in app/jquery, do you
think I should add a version string to the name? Ut's a checkout from trunk at
rev 54.

http://codereview.appspot.com/82041/diff/1/6
File app/soc/content/js/ui.dialog.js (right):

http://codereview.appspot.com/82041/diff/1/6#newcode1
Line 1: /*
On 2009/06/21 10:35:47, Mario Ferraro wrote:
> This file should be in app/jquery directory with name jquery-ui.dialog.js

Done.

http://codereview.appspot.com/82041/diff/1/7
File app/soc/content/js/ui.draggable.js (right):

http://codereview.appspot.com/82041/diff/1/7#newcode1
Line 1: /*
On 2009/06/21 10:35:47, Mario Ferraro wrote:
> This file should be in app/jquery directory with name jquery-ui.draggable.js

Done.

http://codereview.appspot.com/82041/diff/1/8
File app/soc/content/js/ui.sortable.js (right):

http://codereview.appspot.com/82041/diff/1/8#newcode1
Line 1: /*
On 2009/06/21 10:35:47, Mario Ferraro wrote:
> This file should be in app/jquery directory with name jquery-ui.sortable.js

Done.

[Mario Ferraro, 2009-06-23 16:28:42]

http://codereview.appspot.com/82041/diff/12/1016
File app/jquery/jquery.growfield.js (right):

http://codereview.appspot.com/82041/diff/12/1016#newcode1
Line 1: /*
Name should be jquery-growfield.js, not jquery.growfield.js :)
I think it's useful to have the version in some way, but adding it in the name
of the file as we're doing can be quite painful to manage in the long time,
going to mail the group about it. :)

[ajaksu, 2009-06-26 14:56:15]

I think we should merge as-is, then rename to versioned on next update if we go
the version in filenames way :)

http://codereview.appspot.com/82041/diff/12/1016
File app/jquery/jquery.growfield.js (right):

http://codereview.appspot.com/82041/diff/12/1016#newcode1
Line 1: /*
On 2009/06/23 16:28:42, Mario Ferraro wrote:
> Name should be jquery-growfield.js, not jquery.growfield.js :)
> I think it's useful to have the version in some way, but adding it in the name
> of the file as we're doing can be quite painful to manage in the long time,
> going to mail the group about it. :)

Done.