Helper scripts

[ced, 2010-04-03 16:39:50]

http://codereview.appspot.com/820043/diff/1/2
File translate_countries_debian.py (right):

http://codereview.appspot.com/820043/diff/1/2#newcode13
translate_countries_debian.py:13: Copyright (C) 2008-2010 B2CK SPRL.
I don't understand why I'm there :-)

http://codereview.appspot.com/820043/diff/1/2#newcode47
translate_countries_debian.py:47: import pysocket
I think it will be better for preference and code to use directly trytond as a
module.

http://codereview.appspot.com/820043/diff/1/2#newcode60
translate_countries_debian.py:60: LOCALE = 'de_DE'
It could be command line arguments

http://codereview.appspot.com/820043/diff/1/2#newcode91
translate_countries_debian.py:91: iso_translation =  os.popen('isoquery
--locale=' \
Why not use pycountry?
http://pypi.python.org/pypi/pycountry/

[yangoon1, 2010-04-03 19:32:41]

http://codereview.appspot.com/820043/diff/1/2
File translate_countries_debian.py (right):

http://codereview.appspot.com/820043/diff/1/2#newcode13
translate_countries_debian.py:13: Copyright (C) 2008-2010 B2CK SPRL.
On 2010/04/03 16:39:50, ced wrote:
> I don't understand why I'm there :-)

1) I am using code (examples) from you
2) you are just entitled by this to fight copyright infringements. FSF
recommends for this even to put FSF in the copyright.

If you prefer I can remove B2CK, of course.

http://codereview.appspot.com/820043/diff/1/2#newcode47
translate_countries_debian.py:47: import pysocket
On 2010/04/03 16:39:50, ced wrote:
> I think it will be better for preference and code to use directly trytond as a
> module.

Ok.

http://codereview.appspot.com/820043/diff/1/2#newcode60
translate_countries_debian.py:60: LOCALE = 'de_DE'
On 2010/04/03 16:39:50, ced wrote:
> It could be command line arguments

Ok.

http://codereview.appspot.com/820043/diff/1/2#newcode91
translate_countries_debian.py:91: iso_translation =  os.popen('isoquery
--locale=' \
On 2010/04/03 16:39:50, ced wrote:
> Why not use pycountry?
> http://pypi.python.org/pypi/pycountry/

pycountry:
0.11 (2009-03-03)
    * Updated Debian repository to r1752.
The package includes a copy from Debian's pkg-isocodes and makes the data
accessible through a Python API.

Debian:
# [2010-04-03] Accepted 3.15-1 in unstable (low) (Tobias Quathamer)
# [2010-03-12] iso-codes 3.14-1 MIGRATED to testing (Britney)

iso-codes from Debian seems to be far more actual than pycountry, which pulls
from it.

[ced, 2010-04-03 20:11:12]

http://codereview.appspot.com/820043/diff/1/2
File translate_countries_debian.py (right):

http://codereview.appspot.com/820043/diff/1/2#newcode13
translate_countries_debian.py:13: Copyright (C) 2008-2010 B2CK SPRL.
On 2010/04/03 19:32:41, yangoon wrote:
> On 2010/04/03 16:39:50, ced wrote:
> > I don't understand why I'm there :-)
> 
> 1) I am using code (examples) from you
> 2) you are just entitled by this to fight copyright infringements. FSF
> recommends for this even to put FSF in the copyright.
> 
> If you prefer I can remove B2CK, of course.

As you want. I put copyright notice only on code that I want to protect, other
are just as-is.

http://codereview.appspot.com/820043/diff/1/2#newcode91
translate_countries_debian.py:91: iso_translation =  os.popen('isoquery
--locale=' \
On 2010/04/03 19:32:41, yangoon wrote:
> On 2010/04/03 16:39:50, ced wrote:
> > Why not use pycountry?
> > http://pypi.python.org/pypi/pycountry/
> 
> pycountry:
> 0.11 (2009-03-03)
>     * Updated Debian repository to r1752.
> The package includes a copy from Debian's pkg-isocodes and makes the data
> accessible through a Python API.
> 
> Debian:
> # [2010-04-03] Accepted 3.15-1 in unstable (low) (Tobias Quathamer)
> # [2010-03-12] iso-codes 3.14-1 MIGRATED to testing (Britney)
> 
> iso-codes from Debian seems to be far more actual than pycountry, which pulls
> from it. 

But it will be more pythonic. And will work on other distribution per example I
don't have iso-codes on Gentoo

[yangoon1, 2010-04-04 09:43:58]

On 2010/04/03 20:11:12, ced wrote:

> But it will be more pythonic. 

Agreed.

> And will work on other distribution per example I
> don't have iso-codes on Gentoo

There is no pycountry on Debian (via dpkg/apt)

I will try to provide both ways (for the sake of Gentoo users;-) )

[bch, 2010-04-08 10:24:56]

http://codereview.appspot.com/820043/diff/8001/9001
File translate_countries.py (right):

http://codereview.appspot.com/820043/diff/8001/9001#newcode98
translate_countries.py:98: ('lang', '=', LOCALE),
Should be:

('lang', '=', locale),

http://codereview.appspot.com/820043/diff/8001/9002
File translate_currencies.py (right):

http://codereview.appspot.com/820043/diff/8001/9002#newcode98
translate_currencies.py:98: ('lang', '=', LOCALE),
Should be:
('lang', '=', locale),

[bch, 2010-04-08 13:19:04]

On 2010/04/08 11:49:52, yangoon wrote:
> 
OK for me.