Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1751)

Issue 8188044: Allows outside staff positioning for vertical axis groups with no staff (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by MikeSol
Modified:
11 years ago
Reviewers:
Keith, mike7
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Allows outside staff positioning for vertical axis groups with no staff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M lily/axis-group-interface.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Keith
Why not use the flat-line for empty VerticalAxisGroups specifically in side-position-interface.cc when placing something against ...
11 years, 1 month ago (2013-03-30 06:33:10 UTC) #1
Keith
Simpler to just reverse the "special X-alignment" commit. The old code, that followed the comment ...
11 years, 1 month ago (2013-03-30 08:29:39 UTC) #2
mike7
On 30 mars 2013, at 08:33, k-ohara5a5a@oco.net wrote: > Why not use the flat-line for ...
11 years, 1 month ago (2013-03-30 09:13:51 UTC) #3
mike7
11 years, 1 month ago (2013-03-30 09:17:02 UTC) #4
On 30 mars 2013, at 10:29, k-ohara5a5a@oco.net wrote:

> Simpler to just reverse the "special X-alignment" commit.
> 
> The old code, that followed the comment about a 'kldge' whatever that
> means, was rather elegant.  If we are placing something alongside an
> empty set, place it against the reference point for that set.  Having a
> special case for StanzaNumbers and another special case for empty
> VerticalAxisGroups gets messy.
> 
> https://codereview.appspot.com/8188044/

Fair enough, revert and I'll add a comment.

Cheers,
MS

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b