Changed the default character set to be UNICODE, the same as chromium. Change...

Changed the default character set to be UNICODE, the same as chromium. Changes to fix compile errors and warnings.

[dgkoch, 2010-04-07 15:48:18]

no issues here.

[kbr1, 2010-04-07 16:17:14]

LGTM

[Alok Priyadarshi, 2010-04-07 16:17:47]

It seems CreateWindowA is still interpreting window title as unicode string and
outputs junk. Why are ASCII version even provided when they do not work?

I am tempted to remove OutputDebugString entirely because it is windows-only and
not being used anyway. And convert char* to LPTSTR in samples. The samples are
windows-only so it should not matter.

[Alok Priyadarshi, 2010-04-07 16:39:11]

Please review again. Sorry for sending it twice.

[kbr1, 2010-04-07 17:00:52]

I'm dubious that the ASCII versions of the Win32 entry points would be broken.
Have you created a standalone test case and verified how the character set is
selected? Perhaps an unsupported combination of compiler or linker flags caused
the breakage.

http://codereview.appspot.com/816046/diff/8001/9011
File samples/gles2_book/Common/esUtil_win.h (right):

http://codereview.appspot.com/816046/diff/8001/9011#newcode45
samples/gles2_book/Common/esUtil_win.h:45: GLboolean WinCreate ( ESContext
*esContext, LPCTSTR title );
Are these utility functions theoretically supposed to be cross-platform? If so,
the use of LPCTSTR in the signature is going to prevent building on other
platforms.

[Alok Priyadarshi, 2010-04-07 17:09:03]

Hi Ken,
The project compiled fine without any warning when I explicitly used the ASCII
version. But the window title was all garbage. I tried a few compiler settings,
but it did not help.

http://codereview.appspot.com/816046/diff/8001/9011
File samples/gles2_book/Common/esUtil_win.h (right):

http://codereview.appspot.com/816046/diff/8001/9011#newcode45
samples/gles2_book/Common/esUtil_win.h:45: GLboolean WinCreate ( ESContext
*esContext, LPCTSTR title );
This is all windows-only. The samples are supposed to test ANGLE (not the GLSL
translator), which is windows-only.

[kbr1, 2010-04-07 17:57:54]

On 2010/04/07 17:09:03, alokp wrote:
> Hi Ken,
> The project compiled fine without any warning when I explicitly used the ASCII
> version. But the window title was all garbage. I tried a few compiler
settings,
> but it did not help.

I still think it's more likely that there was a bug in the project settings than
the ASCII versions of the Windows APIs. Regardless, since these samples are all
Windows-only and using TCHAR is more correct anyway, LGTM.

[dgkoch, 2010-04-07 19:55:41]

Looks good here.