Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(206)

Issue 8147045: remove more evil code

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by lemniskata.bernoulliego
Modified:
6 years, 1 month ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

remove more evil code remove evil code finger-engraver ok this time - move some stuff to later stage changes in new-fingering-engraver - works 2245 for dynamics (notecolumn as parent) get rid of dynamic closure - not needed anymore draft: fix dynamics allow different alignment for me and parent - tidy version If a grob's parent is a PaperColumn, align using NoteColumn extent. This makes unassociated lyrics behave consistently with associated lyrics. Until now, unassociated lyrics (lyrics without an associatedVoice) were all left-aligned (more precisely: their X-offset was 0). Changing self-alignment-X didn't have any effect on them. This was because X-parent of an unassociated LyricText is a PaperColumn, and aligned_on_parent didn't know how to handle that. This patch tells aligned_on_parent to use the extent of respective NoteColumn as the parent extent needed for grob alignment. Additionally to fixing unassociated lyrics behaviour, this should allow correctly aligning_on_parent other grobs, such as DynamicTexts. Expected changes in regtests: all lyrics should now be centered by default. This affects 11 regtests. Rewrite self_alignment_interface, introduce align_grob (issue 3239) Reduce code duplication: replace aligned_on_parent, aligned_on_self and centered_on_object with align_grob. All changes are internal and not visible to the user - offset callbacks should continue to work exactly the same as before. There should be no changes in Lily behaviour from this commit. More changes to alignment interface are expected to follow: - allowing different alignment for grob and its parent, - cleanup of grob definitions (define-grobs.scm etc.), - aligning on grobs other than respective parent, - ...

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -155 lines) Patch
A input/regression/unassociated-lyrics-alignment.ly View 1 chunk +24 lines, -0 lines 0 comments Download
M lily/dynamic-engraver.cc View 1 chunk +1 line, -2 lines 0 comments Download
M lily/fingering-engraver.cc View 2 chunks +14 lines, -8 lines 0 comments Download
M lily/grob-closure.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M lily/include/grob.hh View 1 chunk +0 lines, -1 line 0 comments Download
M lily/include/paper-column.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/include/self-alignment-interface.hh View 1 chunk +2 lines, -5 lines 0 comments Download
M lily/new-dynamic-engraver.cc View 1 chunk +1 line, -2 lines 0 comments Download
M lily/new-fingering-engraver.cc View 2 chunks +10 lines, -4 lines 0 comments Download
M lily/paper-column.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M lily/self-alignment-interface.cc View 3 chunks +96 lines, -88 lines 0 comments Download
M ly/engraver-init.ly View 1 chunk +0 lines, -7 lines 0 comments Download
M scm/define-grob-properties.scm View 1 chunk +2 lines, -2 lines 0 comments Download
M scm/define-grobs.scm View 1 chunk +1 line, -1 line 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b