Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(564)

Issue 81330046: Bad positioning of tuplet numbers on kneed beams with Beam.positions override.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by david.nalesnik
Modified:
10 years ago
Reviewers:
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Bad positioning of tuplet numbers on kneed beams with Beam.positions override. Previously, when Beam.positions was overridden, tuplet numbers on kneed beams would automatically be placed according to the bracket instead of against the beam. This happened because the check for whether the beam was kneed or not returned false in such cases. This patch replaces that check. It also: --adds a regtest demonstrating behavior with Beam.position overrides --removes some redundant code

Patch Set 1 #

Patch Set 2 : retry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -5 lines) Patch
A input/regression/tuplet-number-kneed-beam-positions.ly View 1 chunk +39 lines, -0 lines 0 comments Download
M lily/tuplet-number.cc View 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 1
david.nalesnik
10 years ago (2014-03-29 14:36:48 UTC) #1
Please review.  Thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b