Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(801)

Issue 81220043: Fix infinite loop in Completion_heads_engraver at invalid measure position (issue 3888).

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by Devon Schudy
Modified:
10 years ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix infinite loop in Completion_heads_engraver at invalid measure position (issue 3888). * Completion_heads_engraver now gives a programming_error instead of trying to make negative-duration notes. * intlog2 with a nonpositive argument now gives an error instead of an infinite loop. Warn when \time is used in mid-measure, and reset measurePosition so it stays valid. This makes issues 3696 and 3888 less mysterious.

Patch Set 1 #

Patch Set 2 : \partial no longer makes measurePosition negative except at the beginning of a score. \time in midm… #

Total comments: 4

Patch Set 3 : Minor changes to formatting and translatability. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -7 lines) Patch
M Documentation/notation/rhythms.itely View 1 1 chunk +3 lines, -4 lines 0 comments Download
A input/regression/time-signature-midmeasure.ly View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
M lily/completion-note-heads-engraver.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M lily/misc.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/partial-iterator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M scm/define-music-callbacks.scm View 1 2 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 4
Devon Schudy
\partial no longer makes measurePosition negative except at the beginning of a score. \time in ...
10 years ago (2014-03-27 22:34:08 UTC) #1
lemzwerg
Thanks for working on this! https://codereview.appspot.com/81220043/diff/20001/input/regression/time-signature-midmeasure.ly File input/regression/time-signature-midmeasure.ly (right): https://codereview.appspot.com/81220043/diff/20001/input/regression/time-signature-midmeasure.ly#newcode5 input/regression/time-signature-midmeasure.ly:5: except in an anacrusis ...
10 years ago (2014-03-28 05:37:19 UTC) #2
Devon Schudy
Minor changes to formatting and translatability.
10 years ago (2014-03-28 20:46:11 UTC) #3
lemzwerg
10 years ago (2014-03-28 21:32:45 UTC) #4
LGTM now, thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b