Issue 802047: Added support for loops.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 802047: Added support for loops. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by Alok Priyadarshi

Modified:
14 years, 7 months ago

Reviewers:
kbr1

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : '' #

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -2 lines)			Patch
	M	src/compiler/OutputGLSL.cpp	View	1	1 chunk	+43 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

kbr1

http://codereview.appspot.com/802047/diff/1/2 File src/compiler/OutputGLSL.cpp (right): http://codereview.appspot.com/802047/diff/1/2#newcode508 src/compiler/OutputGLSL.cpp:508: } What happens when a "while(cond) { }" loop ...

14 years, 7 months ago (2010-03-31 00:15:45 UTC) #2

Alok Priyadarshi

14 years, 7 months ago (2010-03-31 03:08:53 UTC) #3

kbr1

14 years, 7 months ago (2010-03-31 18:06:38 UTC) #4

LGTM

http://codereview.appspot.com/802047/diff/1/2
File src/compiler/OutputGLSL.cpp (right):

http://codereview.appspot.com/802047/diff/1/2#newcode508
src/compiler/OutputGLSL.cpp:508: }
On 2010/03/31 03:08:53, alokp wrote:
> Yes that's exactly what happens to a while loop. I can distinguish between and
> for-loop and while-loop by looking at whether init and terminal blocks are
> available. But does it matter?

Probably not. It might be a little surprising but I suppose we also couldn't
distinguish "for (;cond;) {}" from being translated into while loops. It's fine
as is.

Expand All Messages | Collapse All Messages