Issue 8009043: Use boxes rather than skyline for text; issue 3268

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8009043: Use boxes rather than skyline for text; issue 3268 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by Keith

Modified:
10 years, 11 months ago

Reviewers:
janek

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Use boxes rather than skyline for text; issue 3268

Patch Set 2 : Use skylines, but with a bit of padding #

Created: 10 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
M	input/regression/text-script-vertical-skylines.ly	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ly/property-init.ly	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	scm/define-grobs.scm	View	1	3 chunks	+3 lines, -0 lines	0 comments	Download
M	scm/script.scm	View	1	3 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Keith

https://codereview.appspot.com/8009043/diff/1/input/regression/text-script-vertical-skylines.ly File input/regression/text-script-vertical-skylines.ly (left): https://codereview.appspot.com/8009043/diff/1/input/regression/text-script-vertical-skylines.ly#oldcode13 input/regression/text-script-vertical-skylines.ly:13: } no newline at end of file

11 years, 1 month ago (2013-03-25 06:01:03 UTC) #1

janek

11 years, 1 month ago (2013-03-25 12:01:22 UTC) #2

LBTM - see comment in tracker issue:
http://code.google.com/p/lilypond/issues/detail?id=3268#c6

Expand All Messages | Collapse All Messages