Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(189)

Issue 800: Database2Versions table, get/set version operations implemented (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by Dimitri
Modified:
2 months ago
Reviewers:
Aaron, google-gears-eng, Scott.Hess
SVN Base:
http://google-gears.googlecode.com/svn/contrib/dimitri.glazkov/database2/

Description

Permissions database components, necessary for implementing Database2 API
versioning (http://code.google.com/p/google-gears/wiki/Database2API#Versioning)
added.

I attempted to follow existing Permissions DB conventions/structure as closely
as possible.

Patch Set 1

Total comments: 6

Patch Set 2 : renamed table to Database2Metadata

Total comments: 2

Messages

Total messages: 4
Aaron
http://codereview.appspot.com/800/diff/1/5 File gears/base/common/database2_versions_table.cc (right): http://codereview.appspot.com/800/diff/1/5#newcode117 Line 117: bool Database2VersionsTable::MaybeCreateTableLatestVersion() { Let's just call this CreateTableVersion8() ...
2 months, 1 week ago
Dimitri
Updated, ready for another look. http://codereview.appspot.com/800/diff/1/5 File gears/base/common/database2_versions_table.cc (right): http://codereview.appspot.com/800/diff/1/5#newcode117 Line 117: bool Database2VersionsTable::MaybeCreateTableLatestVersion() { ...
2 months ago
Scott.Hess
I'm not totally in agreement with Aaron about exposing the Database2Metadata object to PermissionsDB clients. ...
2 months ago
Dimitri
2 months ago
This issue is now part of http://codereview.appspot.com/1145, closing this one.
Sign in to reply to this message.

Powered by Google App Engine
This is Rietveld r168