Issue 79760043: Issue 1725 : Email Links in Instructor feedback page

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 79760043: Issue 1725 : Email Links in Instructor feedback page

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by shrianu410

Modified:
10 years, 5 months ago

Reviewers:
arnold.koroa, damith

Visibility:
Public.

More Reviews

Description

Issue 1725 : Email Links in Instructor feedback page

Patch Set 2 : Issue 1725 : Color of link changed to white #

Total comments: 1

Patch Set 3 : Issue 1725 : Changes Updated #

Patch Set 5 : Issue 1725 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -2 lines)			Patch
M	src/main/webapp/jsp/instructorFeedbackResultsByGiver.jsp	View	1 2 3 4	1 chunk	+8 lines, -1 line	0 comments	Download
M	src/main/webapp/jsp/instructorFeedbackResultsByRecipient.jsp	View	1 2	1 chunk	+9 lines, -1 line	0 comments	Download
M	src/main/webapp/stylesheets/instructorFeedbacks.css	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackResultsPageOpen.html	View	1 2 3	5 chunks	+15 lines, -0 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackResultsSortGiver.html	View	1 2 3	3 chunks	+9 lines, -0 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackResultsSortRecipient.html	View	1 2 3	5 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

arnold.koroa

https://codereview.appspot.com/79760043/diff/20001/src/main/webapp/jsp/instructorFeedbackResultsByGiver.jsp File src/main/webapp/jsp/instructorFeedbackResultsByGiver.jsp (right): https://codereview.appspot.com/79760043/diff/20001/src/main/webapp/jsp/instructorFeedbackResultsByGiver.jsp#newcode57 src/main/webapp/jsp/instructorFeedbackResultsByGiver.jsp:57: <%=responsesFromGiver.getValue().get(responsesFromGiver.getValue().keySet().toArray()[0]).get(0).giverEmail%></a> ]</h2> Maybe split these up and assign them ...

10 years, 5 months ago (2014-03-26 09:40:42 UTC) #1

damith

10 years, 5 months ago (2014-04-09 10:06:14 UTC) #2

https://codereview.appspot.com/79760043/diff/60001/src/main/webapp/jsp/instru...
File src/main/webapp/jsp/instructorFeedbackResultsByGiver.jsp (right):

https://codereview.appspot.com/79760043/diff/60001/src/main/webapp/jsp/instru...
src/main/webapp/jsp/instructorFeedbackResultsByGiver.jsp:54: Map<String,
List<FeedbackResponseAttributes> > senderData = responsesFromGiver.getValue();
sender or giver?

https://codereview.appspot.com/79760043/diff/60001/src/main/webapp/jsp/instru...
src/main/webapp/jsp/instructorFeedbackResultsByGiver.jsp:55: Object[]
senderDataArray =  senderData.keySet().toArray();
is this array necessary?

https://codereview.appspot.com/79760043/diff/60001/src/main/webapp/jsp/instru...
src/main/webapp/jsp/instructorFeedbackResultsByGiver.jsp:56: String targetEmail
= senderData.get(senderDataArray[0]).get(0).recipientEmail;
recipientEmail or giverEmail?

Expand All Messages | Collapse All Messages