Issue 7915: [PATCH] SendFeatures hook for additions to stream:features

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7915: [PATCH] SendFeatures hook for additions to stream:features

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 2 months ago by Jacob

Modified:
10 years, 1 month ago

Reviewers:
djabberd

Base URL:
http://code.sixapart.com/svn/djabberd/trunk/DJabberd

Visibility:
Public.

Description

It seems there are some methods on VHost for adding features, but these are intended for us in responding to the http://jabber.org/protocol/disco IQ. A change is needed to allow plugin to insert things into the <features> stanza send after stream start from server to client. Currently, this stanza might look something like: <stream:features><auth xmlns='http://jabber.org/features/iq-auth'/><starttls xmlns='urn:ietf:params:xml:ns:xmpp-tls' /></stream:features>

Patch Set 1 #

Patch Set 2 : A hook for enabling plugins to insert into features stanza #

Created: 16 years, 2 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+147 lines, -1 line)			Patch
lib/DJabberd/Connection.pm	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
lib/DJabberd/HookDocs.pm	View		1 chunk	+7 lines, -0 lines	0 comments	Download
t/features-hook.t	View		1 chunk	+124 lines, -0 lines	0 comments	Download
t/lib/djabberd-test.pl	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dangabrad

Assuming all tests still pass, looks good to me. Feel free to commit.

16 years, 2 months ago (2008-11-04 06:56:59 UTC) #2

Jacob

16 years, 2 months ago (2008-11-10 22:02:20 UTC) #3

A hook for enabling plugins to insert into features stanza

Expand All Messages | Collapse All Messages