Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6566)

Issue 7866043: Prohibit non-postevents returned by music functions to be used as post-events (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by dak
Modified:
11 years, 1 month ago
Reviewers:
janek, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Prohibit non-postevents from music functions to be used as post-events For example, { c-\mark \default } produced an invalid music expression more or less indistinguishable from { \mark \default c } Worse is that things like { c-\tweak color #red { g } } also got accepted. While \tweak (and other music functions) may indeed return either post-events or straight music expressions, there should be checks in place that the usage corresponds to its type. Unfortunately, already make test turned up points of conflict addressed by the following additional patch: Make \balloonText into post-event, \balloonGrobText into proper event This is a stopgap measure for getting some consistency into music function use. The real fix would be to convert \ballonText and \balloonGrobText to the same kind of interface that \footnote uses. Indeed, it might be saner to retire the whole AnnotateOutputEvent folderol and instead just use footnotes without footnote-text. With this patch set, make test succeeds here. I would not be particularly surprised, however, if the documentation compile turned up further problems. After all, the purpose of the patch is to flag previously unnoticed sloppy code, and our documentation contains a lot of code.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M lily/parser.yy View 2 chunks +8 lines, -3 lines 0 comments Download
M ly/music-functions-init.ly View 1 chunk +8 lines, -6 lines 0 comments Download
M scm/define-music-types.scm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
lemzwerg
LGTM.
11 years, 1 month ago (2013-03-16 15:57:07 UTC) #1
janek
11 years, 1 month ago (2013-03-17 15:51:51 UTC) #2
commit message says:
> Prohibit non-postevents from music functions to be used
> as post-event

Do i understand correctly that this sentence is equivalent to "Prohibit
non-postevents returned by music functions to be used as post-events"?  If so,
i'd prefer that second wording; the original looks less straighforward to me.

thanks,
Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b