Issue 78056: Make sure we have a non-null FreeType face before dereferencing it.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 78056: Make sure we have a non-null FreeType face before dereferencing it. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 6 months ago by deanm

Modified:
15 years, 5 months ago

Reviewers:
reed

Visibility:
Public.

Description

Make sure we have a non-null FreeType face before dereferencing it. This prevents a NULL pointer crash in generateFontMetrics with some fonts. Patch by Lei Zhang. Original Chromium bug: http://code.google.com/p/chromium/issues/detail?id=13007

Patch Set 1 #

Created: 15 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/ports/SkFontHost_FreeType.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

deanm

15 years, 6 months ago (2009-06-19 08:56:58 UTC) #1

Hey Mike,

This is a really simple change so I'm going to commit it without review.  I am
trying to get Chrome using the new version of Skia today, so it makes sense to
do it all at once.

Thanks

Expand All Messages | Collapse All Messages