Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(297)

Issue 78056: Make sure we have a non-null FreeType face before dereferencing it. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 5 months ago by deanm
Modified:
15 years, 4 months ago
Reviewers:
reed
Visibility:
Public.

Description

Make sure we have a non-null FreeType face before dereferencing it. This prevents a NULL pointer crash in generateFontMetrics with some fonts. Patch by Lei Zhang. Original Chromium bug: http://code.google.com/p/chromium/issues/detail?id=13007

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/ports/SkFontHost_FreeType.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 1
deanm
15 years, 5 months ago (2009-06-19 08:56:58 UTC) #1
Hey Mike,

This is a really simple change so I'm going to commit it without review.  I am
trying to get Chrome using the new version of Skia today, so it makes sense to
do it all at once.

Thanks
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b