Issue 77770043: Issue1725:Include Student Email ID in FeedBackResults Page

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 77770043: Issue1725:Include Student Email ID in FeedBackResults Page

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by shrianu410

Modified:
10 years, 5 months ago

Reviewers:
arnold.koroa

Visibility:
Public.

More Reviews

Description

Issue1725:Include Student Email ID in FeedBackResults Page

Patch Set 2 : Issue:1725 Updates on changed requested #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -15 lines)			Patch
M	src/main/webapp/jsp/instructorFeedbackResultsByGiver.jsp	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/main/webapp/jsp/instructorFeedbackResultsByRecipient.jsp	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/main/webapp/stylesheets/common.css	View	1	1 chunk	+5 lines, -0 lines	1 comment	Download
M	src/test/resources/pages/instructorFeedbackResultsPageOpen.html	View		6 chunks	+32 lines, -5 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackResultsSortGiver.html	View		4 chunks	+22 lines, -3 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackResultsSortRecipient.html	View		6 chunks	+32 lines, -5 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

arnold.koroa

https://codereview.appspot.com/77770043/diff/1/src/main/webapp/jsp/instructorFeedbackResultsByGiver.jsp File src/main/webapp/jsp/instructorFeedbackResultsByGiver.jsp (right): https://codereview.appspot.com/77770043/diff/1/src/main/webapp/jsp/instructorFeedbackResultsByGiver.jsp#newcode20 src/main/webapp/jsp/instructorFeedbackResultsByGiver.jsp:20: { follow TEAMMATES bracket placement standard. See other css ...

10 years, 5 months ago (2014-03-20 05:49:09 UTC) #1

arnold.koroa

10 years, 5 months ago (2014-03-23 06:23:15 UTC) #2

https://codereview.appspot.com/77770043/diff/20001/src/main/webapp/stylesheet...
File src/main/webapp/stylesheets/common.css (right):

https://codereview.appspot.com/77770043/diff/20001/src/main/webapp/stylesheet...
src/main/webapp/stylesheets/common.css:565: }
move to instructorFeedbacks.css? This is only used in the instructor feedback
results page.

Expand All Messages | Collapse All Messages