Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(17)

Issue 7764046: Remove -d old-relative compatibility option (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by dak
Modified:
11 years, 1 month ago
Reviewers:
janek, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Remove -d old-relative compatibility option This removes the lily_1_8_relative variable and the code surrounding it. lily_1_8_relative_used apparently was unused; Scheme code for interpreting its setting was not connected to the actual variable. The callback for repeat-music was not actually being used and has been removed. While the command line option was still documented, it was ineffective: only reenabling it in the file itself lead to any effect. ly:relative-music::relative-callback and ly:relative-music::no-relative-callback are now functionally equivalent.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -101 lines) Patch
M Documentation/changes.tely View 1 chunk +7 lines, -0 lines 0 comments Download
M Documentation/usage/running.itely View 1 chunk +0 lines, -5 lines 0 comments Download
M lily/include/program-option.hh View 1 chunk +0 lines, -2 lines 0 comments Download
M lily/music-scheme.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M lily/music-sequence.cc View 1 chunk +2 lines, -19 lines 0 comments Download
M lily/program-option-scheme.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M lily/relative-octave-music.cc View 1 chunk +3 lines, -17 lines 0 comments Download
M lily/repeated-music.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M ly/declarations-init.ly View 1 chunk +0 lines, -3 lines 0 comments Download
M ly/init.ly View 2 chunks +0 lines, -6 lines 0 comments Download
M python/convertrules.py View 1 chunk +8 lines, -0 lines 0 comments Download
M scm/lily.scm View 1 chunk +0 lines, -3 lines 0 comments Download
M scm/lily-library.scm View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2
lemzwerg
LGTM
11 years, 1 month ago (2013-03-14 13:37:49 UTC) #1
janek
11 years, 1 month ago (2013-03-14 14:17:01 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b