Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7248)

Issue 7763: * Fix DynamicTextSpanner left alignment. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 5 months ago by Neil Puttock
Modified:
14 years, 3 months ago
Reviewers:
joeneeman
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

* Fix DynamicTextSpanner left alignment. When a DynamicTextSpanner follows a DynamicScript, padding is required to ensure the 'left 'text doesn't collide with the dynamic sign. Unfortunately, this default value skews the spanner's left bound to the right when no dynamic script is present. This patch caters for both situations by resetting 'left 'padding as required, adding extra padding read from the script property 'right-padding. Additionally, two minor changes have been made to 'bound-details: - vertical alignment for the left stencil is improved by using 'stencil-align-dir-y instead of 'stencil-offset; - some padding is inserted between the stencil and the line, matching the right bound.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -12 lines) Patch
A input/regression/dynamics-text-left-text-alignment.ly View 1 chunk +12 lines, -0 lines 0 comments Download
M input/regression/dynamics-text-spanner-abs-dynamic.ly View 1 chunk +13 lines, -9 lines 0 comments Download
M lily/new-dynamic-engraver.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M lily/script-interface.cc View 1 chunk +1 line, -0 lines 0 comments Download
M scm/define-grobs.scm View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 2
Neil Puttock
15 years, 5 months ago (2008-11-09 00:47:27 UTC) #1
joeneeman
15 years, 4 months ago (2008-11-29 15:25:37 UTC) #2

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b