rietveld/views.py - Issue 776: Allow reviewers to change the reviewers list

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
j / k :	jump to file after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue


	Comment editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Unified Diff: rietveld/views.py

Issue 776: Allow reviewers to change the reviewers list (Closed) SVN Base: http://rietveld.googlecode.com/svn/trunk/

Patch Set: Minor changes Created 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

View side by-side-diff with in-line comments

Download patch

« index.yaml ('k') | templates/publish.html » ('j') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: rietveld/views.py

===================================================================

--- rietveld/views.py (revision 81)

+++ rietveld/views.py (working copy)

@@ -187,6 +187,9 @@

class MiniPublishForm(forms.Form):

send_mail = forms.BooleanField()

+ reviewers = forms.CharField(required=False,

+ max_length=1000,

+ widget=forms.TextInput(attrs={'size': 60}))

message = forms.CharField(required=False,

max_length=10000,

widget=forms.Textarea(attrs={'cols': 60}))

@@ -572,7 +575,7 @@

if raw_reviewers:

for reviewer in raw_reviewers.split(','):

reviewer = reviewer.strip()

- if reviewer:

+ if reviewer and reviewer not in reviewers:

try:

reviewer = db.Email(reviewer)

if reviewer.count('@') != 1:

@@ -942,8 +945,12 @@

else:

form_class = MiniPublishForm

if request.method != 'POST':

+ reviewers = issue.reviewers[:]

+ if request.user != issue.owner and (request.user.email()

+ not in issue.reviewers):

+ reviewers.append(request.user.email())

form = form_class(initial={'subject': issue.subject,

- 'reviewers': ', '.join(issue.reviewers),

+ 'reviewers': ', '.join(reviewers),

'send_mail': True,

})

return respond(request, 'publish.html', {'form': form, 'issue': issue})

@@ -960,6 +967,7 @@

issue.reviewers = reviewers

else:

subject = issue.subject

+ issue.reviewers = reviewers

tbd.append(issue) # To update the last modified time

message = form.cleaned_data['message'].replace('\r\n', '\n')

send_mail = form.cleaned_data['send_mail']

« index.yaml ('k') | templates/publish.html » ('j')